Source/core/svg/SVGEllipseElement.h - Issue 955033002: [svg2] Make 'rx' and 'ry' presentation attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGEllipseElement.h

Issue 955033002: [svg2] Make 'rx' and 'ry' presentation attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add tests Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGEllipseElement.h

diff --git a/Source/core/svg/SVGEllipseElement.h b/Source/core/svg/SVGEllipseElement.h

index 067faded383b533942558e23b3dbc9dc16cf0a4d..3b22199a303cfc7c43929717e3cae104b3f37f3f 100644

--- a/Source/core/svg/SVGEllipseElement.h

+++ b/Source/core/svg/SVGEllipseElement.h

@@ -41,6 +41,10 @@ public:

DECLARE_VIRTUAL_TRACE();

+ virtual bool isPresentationAttribute(const QualifiedName&) const override;

fs 2015/02/26 14:20:58 Do these need to be public?

Erik Dahlström (inactive) 2015/02/26 16:16:33 Good catch, fixed.

+ virtual bool isPresentationAttributeWithSVGDOM(const QualifiedName&) const override;

+ virtual void collectStyleForPresentationAttribute(const QualifiedName&, const AtomicString&, MutableStylePropertySet*) override;

private:

explicit SVGEllipseElement(Document&);