Chromium Code Reviews Chromium Code Reviews
Issue 955033002:
[svg2] Make 'rx' and 'ry' presentation attributes (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org> | 2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org> |
| 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> | 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> |
| 4 * | 4 * |
| 5 * This library is free software; you can redistribute it and/or | 5 * This library is free software; you can redistribute it and/or |
| 6 * modify it under the terms of the GNU Library General Public | 6 * modify it under the terms of the GNU Library General Public |
| 7 * License as published by the Free Software Foundation; either | 7 * License as published by the Free Software Foundation; either |
| 8 * version 2 of the License, or (at your option) any later version. | 8 * version 2 of the License, or (at your option) any later version. |
| 9 * | 9 * |
| 10 * This library is distributed in the hope that it will be useful, | 10 * This library is distributed in the hope that it will be useful, |
| (...skipping 23 matching lines...) Expand all Loading... | |
| 34 public: | 34 public: |
| 35 DECLARE_NODE_FACTORY(SVGEllipseElement); | 35 DECLARE_NODE_FACTORY(SVGEllipseElement); |
| 36 | 36 |
| 37 SVGAnimatedLength* cx() const { return m_cx.get(); } | 37 SVGAnimatedLength* cx() const { return m_cx.get(); } |
| 38 SVGAnimatedLength* cy() const { return m_cy.get(); } | 38 SVGAnimatedLength* cy() const { return m_cy.get(); } |
| 39 SVGAnimatedLength* rx() const { return m_rx.get(); } | 39 SVGAnimatedLength* rx() const { return m_rx.get(); } |
| 40 SVGAnimatedLength* ry() const { return m_ry.get(); } | 40 SVGAnimatedLength* ry() const { return m_ry.get(); } |
| 41 | 41 |
| 42 DECLARE_VIRTUAL_TRACE(); | 42 DECLARE_VIRTUAL_TRACE(); |
| 43 | 43 |
| 44 virtual bool isPresentationAttribute(const QualifiedName&) const override; | |
|
fs
2015/02/26 14:20:58
Do these need to be public?
Erik Dahlström (inactive)
2015/02/26 16:16:33
Good catch, fixed.
| |
| 45 virtual bool isPresentationAttributeWithSVGDOM(const QualifiedName&) const o verride; | |
| 46 virtual void collectStyleForPresentationAttribute(const QualifiedName&, cons t AtomicString&, MutableStylePropertySet*) override; | |
| 47 | |
| 44 private: | 48 private: |
| 45 explicit SVGEllipseElement(Document&); | 49 explicit SVGEllipseElement(Document&); |
| 46 | 50 |
| 47 bool isSupportedAttribute(const QualifiedName&); | 51 bool isSupportedAttribute(const QualifiedName&); |
| 48 virtual void parseAttribute(const QualifiedName&, const AtomicString&) overr ide; | 52 virtual void parseAttribute(const QualifiedName&, const AtomicString&) overr ide; |
| 49 virtual void svgAttributeChanged(const QualifiedName&) override; | 53 virtual void svgAttributeChanged(const QualifiedName&) override; |
| 50 | 54 |
| 51 virtual bool selfHasRelativeLengths() const override; | 55 virtual bool selfHasRelativeLengths() const override; |
| 52 | 56 |
| 53 virtual LayoutObject* createRenderer(const LayoutStyle&) override; | 57 virtual LayoutObject* createRenderer(const LayoutStyle&) override; |
| 54 | 58 |
| 55 RefPtrWillBeMember<SVGAnimatedLength> m_cx; | 59 RefPtrWillBeMember<SVGAnimatedLength> m_cx; |
| 56 RefPtrWillBeMember<SVGAnimatedLength> m_cy; | 60 RefPtrWillBeMember<SVGAnimatedLength> m_cy; |
| 57 RefPtrWillBeMember<SVGAnimatedLength> m_rx; | 61 RefPtrWillBeMember<SVGAnimatedLength> m_rx; |
| 58 RefPtrWillBeMember<SVGAnimatedLength> m_ry; | 62 RefPtrWillBeMember<SVGAnimatedLength> m_ry; |
| 59 }; | 63 }; |
| 60 | 64 |
| 61 } // namespace blink | 65 } // namespace blink |
| 62 | 66 |
| 63 #endif // SVGEllipseElement_h | 67 #endif // SVGEllipseElement_h |
| OLD | NEW |
