Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 955033002: [svg2] Make 'rx' and 'ry' presentation attributes (Closed)

Created:
5 years, 10 months ago by Erik Dahlström (inactive)
Modified:
5 years, 10 months ago
Reviewers:
pdr., fs
CC:
blink-reviews, shans, eae+blinkwatch, fs, apavlov+blink_chromium.org, Steve Block, rwlbuis, krit, blink-reviews-css, Timothy Loh, dstockwell, dglazkov+blink, jchaffraix+rendering, pdr+svgwatchlist_chromium.org, Eric Willigers, rjwright, blink-reviews-style_chromium.org, zoltan1, Dominik Röttsches, gyuyoung.kim_webkit.org, darktears, blink-reviews-rendering, blink-reviews-animation_chromium.org, pdr+renderingwatchlist_chromium.org, kouhei+svg_chromium.org, leviw+renderwatch, Mike Lawther (Google), ed+blinkwatch_opera.com, f(malita), Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[svg2] Make 'rx' and 'ry' presentation attributes The following elements' rx and ry attributes have been made into presentation attributes: * rect * ellipse Spec: https://svgwg.org/svg2-draft/geometry.html#RXProperty https://svgwg.org/svg2-draft/geometry.html#RYProperty BUG=400725 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190937

Patch Set 1 #

Patch Set 2 : bugfixing #

Patch Set 3 : add tests #

Total comments: 8

Patch Set 4 : review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -37 lines) Patch
M LayoutTests/svg/css/parse-length.html View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
M LayoutTests/svg/css/parse-length-expected.txt View 1 2 2 chunks +34 lines, -0 lines 0 comments Download
M LayoutTests/transitions/svg-layout-transition.html View 1 2 3 4 chunks +24 lines, -5 lines 0 comments Download
M LayoutTests/transitions/svg-layout-transition-expected.txt View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/animation/css/CSSPropertyEquality.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M Source/core/css/CSSProperties.in View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/LayoutStyleCSSValueMapping.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSParserFastPaths.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/resolver/AnimatedStyleBuilder.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/layout/style/LayoutStyle.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/style/SVGLayoutStyle.h View 3 chunks +14 lines, -0 lines 0 comments Download
M Source/core/layout/style/SVGLayoutStyle.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/layout/style/SVGLayoutStyleDefs.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/style/SVGLayoutStyleDefs.cpp View 3 chunks +7 lines, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGRect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/SVGPathData.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M Source/core/svg/SVGElement.h View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M Source/core/svg/SVGEllipseElement.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/svg/SVGEllipseElement.cpp View 1 2 chunks +37 lines, -3 lines 0 comments Download
M Source/core/svg/SVGRectElement.h View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/svg/SVGRectElement.cpp View 1 3 chunks +16 lines, -10 lines 0 comments Download
M Source/core/svg/SVGUseElement.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Erik Dahlström (inactive)
5 years, 10 months ago (2015-02-26 12:23:08 UTC) #2
fs
lgtm https://codereview.chromium.org/955033002/diff/40001/LayoutTests/transitions/svg-layout-transition.html File LayoutTests/transitions/svg-layout-transition.html (right): https://codereview.chromium.org/955033002/diff/40001/LayoutTests/transitions/svg-layout-transition.html#newcode53 LayoutTests/transitions/svg-layout-transition.html:53: for (var i = 0; i < expectedValues.length; ...
5 years, 10 months ago (2015-02-26 14:20:58 UTC) #3
Erik Dahlström (inactive)
https://codereview.chromium.org/955033002/diff/40001/LayoutTests/transitions/svg-layout-transition.html File LayoutTests/transitions/svg-layout-transition.html (right): https://codereview.chromium.org/955033002/diff/40001/LayoutTests/transitions/svg-layout-transition.html#newcode53 LayoutTests/transitions/svg-layout-transition.html:53: for (var i = 0; i < expectedValues.length; i++) ...
5 years, 10 months ago (2015-02-26 16:16:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955033002/60001
5 years, 10 months ago (2015-02-26 16:18:06 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 17:47:41 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190937

Powered by Google App Engine
This is Rietveld 408576698