Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 955003002: Subzero: Clean up function header emission. (Closed)

Created:
5 years, 10 months ago by Jim Stichnoth
Modified:
5 years, 9 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Clean up function header emission. 1. Don't do anything in Cfg::emitTextHeader() in MINIMAL mode. (Reduces binary size by 1KB.) This actually broke a number of lit tests for the MINIMAL build, so "--assemble --disassemble" was changed to "--filetype=obj --disassemble". This allowed (or required) better precision in checking for data symbols. 1a. For the lit files touched, go ahead and remove "-verbose none" since that will forevermore by the default. 2. Don't emit the ".bundle_align_mode" directive. This is not necessary when assembling with the right -triple argument. BUG= none R=jvoung@chromium.org, kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=729dbd0194c1aa39c41911cd29efeb19c5ea1178

Patch Set 1 #

Patch Set 2 : Fix the tests that were broken as a result #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -192 lines) Patch
M src/IceCfg.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/IceELFObjectWriter.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests_lit/assembler/x86/immediate_encodings.ll View 1 1 chunk +1 line, -2 lines 0 comments Download
M tests_lit/assembler/x86/jump_encodings.ll View 1 1 chunk +1 line, -1 line 0 comments Download
M tests_lit/assembler/x86/opcode_register_encodings.ll View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/assembler/x86/sandboxing.ll View 1 1 chunk +1 line, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/64bit.pnacl.ll View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/8bit.pnacl.ll View 1 1 chunk +2 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/address-mode-opt.ll View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/align-spill-locations.ll View 1 1 chunk +2 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/alloc.ll View 1 1 chunk +2 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/bitcast.ll View 1 1 chunk +2 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/bool-opt.ll View 1 1 chunk +1 line, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/branch-opt.ll View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/callindirect.pnacl.ll View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/cmp-opt.ll View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/convert.ll View 1 9 chunks +31 lines, -34 lines 0 comments Download
M tests_lit/llvm2ice_tests/div_legalization.ll View 1 1 chunk +2 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/ebp_args.ll View 1 1 chunk +1 line, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/elf_function_sections.ll View 1 1 chunk +9 lines, -6 lines 0 comments Download
M tests_lit/llvm2ice_tests/elf_nodata.ll View 1 1 chunk +8 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/fp.pnacl.ll View 1 1 chunk +2 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/fpcall.ll View 1 1 chunk +2 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/function_aligned.ll View 1 1 chunk +1 line, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/ias-multi-reloc.ll View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/nacl-atomic-cmpxchg-optimization.ll View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-atomic-fence-all.ll View 1 5 chunks +12 lines, -13 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-atomic-intrinsics.ll View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/phi.ll View 1 1 chunk +1 line, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/randomize-regalloc.ll View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/returns_twice_no_coalesce.ll View 1 1 chunk +1 line, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/sdiv.ll View 1 1 chunk +2 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/select-opt.ll View 1 1 chunk +2 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/shift.ll View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/simple-loop.ll View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/switch-opt.ll View 1 1 chunk +1 line, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/test_i1.ll View 1 1 chunk +2 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/undef.ll View 1 1 chunk +6 lines, -6 lines 0 comments Download
M tests_lit/llvm2ice_tests/unreachable.ll View 1 1 chunk +2 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-arg.ll View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-arith.ll View 1 1 chunk +5 lines, -5 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-bitcast.ll View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-cast.ll View 1 1 chunk +2 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-fcmp.ll View 1 1 chunk +2 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-icmp.ll View 1 1 chunk +2 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-ops.ll View 1 1 chunk +6 lines, -6 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-select.ll View 1 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Karl
lgtm
5 years, 9 months ago (2015-02-25 17:48:32 UTC) #2
Jim Stichnoth
PTAL. It was originally a very simple change, and I added reviewers to the CL ...
5 years, 9 months ago (2015-02-25 20:27:31 UTC) #3
jvoung (off chromium)
lgtm yikes
5 years, 9 months ago (2015-02-25 21:32:34 UTC) #4
Jim Stichnoth
5 years, 9 months ago (2015-02-25 22:48:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
729dbd0194c1aa39c41911cd29efeb19c5ea1178 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698