src/IceELFObjectWriter.cpp - Issue 955003002: Subzero: Clean up function header emission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceELFObjectWriter.cpp

Issue 955003002: Subzero: Clean up function header emission. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix the tests that were broken as a result Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceELFObjectWriter.cpp

diff --git a/src/IceELFObjectWriter.cpp b/src/IceELFObjectWriter.cpp

index b8f678ebf4875963cfde149e752688f7a4e10dc7..ff68ba2582621fe7c6eda64d2a12950063d35120 100644

--- a/src/IceELFObjectWriter.cpp

+++ b/src/IceELFObjectWriter.cpp

@@ -370,6 +370,8 @@ void ELFObjectWriter::writeDataOfType(SectionType ST,

if (!Var->hasInitializer())

continue;

Elf64_Xword Align = Var->getAlignment();

+ const Elf64_Xword MinAlign = 1;

+ Align = std::max(Align, MinAlign);

Section->padToAlignment(Str, Align);

SizeT SymbolSize = Var->getNumBytes();

bool IsExternal = Var->isExternal() || Ctx.getFlags().getDisableInternal();

« no previous file with comments | « src/IceCfg.cpp ('k') | tests_lit/assembler/x86/immediate_encodings.ll » ('j') | no next file with comments »