Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 954973004: Move BufferedSocketWriter from remoting/protocol to remoting/base (Closed)

Created:
5 years, 10 months ago by Sergey Ulanov
Modified:
5 years, 10 months ago
Reviewers:
rmsousa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move BufferedSocketWriter from remoting/protocol to remoting/base Currently BufferedSocketWriter is in remoting/protocol and cannot be used in remoting/signaling. Also cleaned up the tests to remove dependency on remoting/protocol. Committed: https://crrev.com/7c4800b8b35a0dc6db9e3576b2e07d29cc37b3a0 Cr-Commit-Position: refs/heads/master@{#318256}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -627 lines) Patch
A + remoting/base/buffered_socket_writer.h View 3 chunks +3 lines, -5 lines 0 comments Download
A + remoting/base/buffered_socket_writer.cc View 3 chunks +2 lines, -4 lines 0 comments Download
A + remoting/base/buffered_socket_writer_unittest.cc View 8 chunks +89 lines, -52 lines 0 comments Download
M remoting/protocol/audio_writer.h View 1 chunk +0 lines, -1 line 0 comments Download
D remoting/protocol/buffered_socket_writer.h View 1 chunk +0 lines, -132 lines 0 comments Download
D remoting/protocol/buffered_socket_writer.cc View 1 chunk +0 lines, -236 lines 0 comments Download
D remoting/protocol/buffered_socket_writer_unittest.cc View 1 chunk +0 lines, -189 lines 0 comments Download
M remoting/protocol/channel_dispatcher_base.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/channel_multiplexer.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/client_control_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/client_event_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/host_control_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/remoting_srcs.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/remoting_test.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Sergey Ulanov
5 years, 10 months ago (2015-02-25 22:13:01 UTC) #2
rmsousa
lgtm
5 years, 10 months ago (2015-02-26 04:32:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954973004/1
5 years, 10 months ago (2015-02-26 17:22:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-26 18:03:17 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 18:03:49 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7c4800b8b35a0dc6db9e3576b2e07d29cc37b3a0
Cr-Commit-Position: refs/heads/master@{#318256}

Powered by Google App Engine
This is Rietveld 408576698