[Extensions] Make chrome://extensions use api functions for file access, reload

[Extensions] Make chrome://extensions use api functions for file access, reload

Make the chrome://extensions page use chrome.developerPrivate API to toggle
file access, and also to reload extensions.
Also add unit tests for the API functions.

BUG=461039
Committed: https://crrev.com/3dccd4c49d97eec3437f1fb74421f46e56c7cedd
Cr-Commit-Position: refs/heads/master@{#318514}

[Devlin, 2015-02-26 00:09:48]

rdevlin.cronin@chromium.org changed reviewers:
+ kalman@chromium.org

[Devlin, 2015-02-26 00:09:48]

Next!

[not at google - send to devlin, 2015-02-26 00:56:48]

lgtm but check supervised user.

https://codereview.chromium.org/954943007/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/developer_private/developer_private_api.cc
(right):

https://codereview.chromium.org/954943007/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:723: if
(!user_gesture())
... drive by I guess?

https://codereview.chromium.org/954943007/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:742:
->GetExtensionById(params->item_id, ExtensionRegistry::EVERYTHING);
Can we pull this huge 3-line "get me installed extension" into a member
function?

https://codereview.chromium.org/954943007/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:746: //
Default to failing "noisily".
comment unnecssary

https://codereview.chromium.org/954943007/diff/1/chrome/browser/ui/webui/exte...
File chrome/browser/ui/webui/extensions/extension_settings_handler.cc (left):

https://codereview.chromium.org/954943007/diff/1/chrome/browser/ui/webui/exte...
chrome/browser/ui/webui/extensions/extension_settings_handler.cc:1089: if
(util::IsExtensionSupervised(extension, Profile::FromWebUI(web_ui())))
Looks like you lost this check in the move to the developer private API.

[Devlin, 2015-02-26 01:14:03]

https://codereview.chromium.org/954943007/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/developer_private/developer_private_api.cc
(right):

https://codereview.chromium.org/954943007/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:723: if
(!user_gesture())
On 2015/02/26 00:56:47, kalman wrote:
> ... drive by I guess?

Yes. :)

https://codereview.chromium.org/954943007/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:742:
->GetExtensionById(params->item_id, ExtensionRegistry::EVERYTHING);
On 2015/02/26 00:56:47, kalman wrote:
> Can we pull this huge 3-line "get me installed extension" into a member
> function?

Was meaning to do that for awhile. Done.

https://codereview.chromium.org/954943007/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:746: //
Default to failing "noisily".
On 2015/02/26 00:56:47, kalman wrote:
> comment unnecssary

Done.

https://codereview.chromium.org/954943007/diff/1/chrome/browser/ui/webui/exte...
File chrome/browser/ui/webui/extensions/extension_settings_handler.cc (left):

https://codereview.chromium.org/954943007/diff/1/chrome/browser/ui/webui/exte...
chrome/browser/ui/webui/extensions/extension_settings_handler.cc:1089: if
(util::IsExtensionSupervised(extension, Profile::FromWebUI(web_ui())))
On 2015/02/26 00:56:48, kalman wrote:
> Looks like you lost this check in the move to the developer private API.

I didn't miss it; it wasn't there when I moved it! ;)  (It really wasn't.) 
Added.

[Devlin, 2015-02-27 18:28:41]

Patchset #3 (id:40001) has been deleted

[Devlin, 2015-02-27 18:28:45]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-02-27 18:28:45]

The patchset sent to the CQ was uploaded after l-g-t-m from kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/954943007/#ps60001 (title:
"Latest master")

[commit-bot: I haz the power, 2015-02-27 18:30:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/954943007/60001

[Devlin, 2015-02-27 20:02:54]

The CQ bit was unchecked by rdevlin.cronin@chromium.org

[Devlin, 2015-02-27 20:19:00]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-02-27 20:19:01]

The patchset sent to the CQ was uploaded after l-g-t-m from kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/954943007/#ps80001 (title:
" ")

[commit-bot: I haz the power, 2015-02-27 20:19:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/954943007/80001

[commit-bot: I haz the power, 2015-02-27 21:05:33]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-02-27 21:06:28]

Patchset 4 (id:??) landed as
https://crrev.com/3dccd4c49d97eec3437f1fb74421f46e56c7cedd
Cr-Commit-Position: refs/heads/master@{#318514}