[Extensions] Make chrome://extensions use api functions for file access, reload

chrome/browser/ui/webui/extensions/extension_settings_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"
 
 #include "apps/app_load_service.h"
 #include "apps/saved_files_service.h"
 #include "base/auto_reset.h"
 #include "base/base64.h"
@@ skipping 673 matching lines @@
                  AsWeakPtr()));
   web_ui()->RegisterMessageCallback("extensionSettingsToggleDeveloperMode",
       base::Bind(&ExtensionSettingsHandler::HandleToggleDeveloperMode,
                  AsWeakPtr()));
   web_ui()->RegisterMessageCallback("extensionSettingsInspect",
       base::Bind(&ExtensionSettingsHandler::HandleInspectMessage,
                  AsWeakPtr()));
   web_ui()->RegisterMessageCallback("extensionSettingsLaunch",
       base::Bind(&ExtensionSettingsHandler::HandleLaunchMessage,
                  AsWeakPtr()));
-  web_ui()->RegisterMessageCallback("extensionSettingsReload",
-      base::Bind(&ExtensionSettingsHandler::HandleReloadMessage,
-                 AsWeakPtr()));
   web_ui()->RegisterMessageCallback("extensionSettingsRepair",
       base::Bind(&ExtensionSettingsHandler::HandleRepairMessage,
                  AsWeakPtr()));
   web_ui()->RegisterMessageCallback("extensionSettingsEnableErrorCollection",
       base::Bind(&ExtensionSettingsHandler::HandleEnableErrorCollectionMessage,
                  AsWeakPtr()));
-  web_ui()->RegisterMessageCallback("extensionSettingsAllowFileAccess",
-      base::Bind(&ExtensionSettingsHandler::HandleAllowFileAccessMessage,
-                 AsWeakPtr()));
   web_ui()->RegisterMessageCallback("extensionSettingsAllowOnAllUrls",
       base::Bind(&ExtensionSettingsHandler::HandleAllowOnAllUrlsMessage,
                  AsWeakPtr()));
   web_ui()->RegisterMessageCallback("extensionSettingsUninstall",
       base::Bind(&ExtensionSettingsHandler::HandleUninstallMessage,
                  AsWeakPtr()));
   web_ui()->RegisterMessageCallback("extensionSettingsOptions",
       base::Bind(&ExtensionSettingsHandler::HandleOptionsMessage,
                  AsWeakPtr()));
   web_ui()->RegisterMessageCallback("extensionSettingsPermissions",
@@ skipping 321 matching lines @@
   std::string extension_id;
   CHECK(args->GetString(0, &extension_id));
   const Extension* extension =
       extension_service_->GetExtensionById(extension_id, false);
   OpenApplication(AppLaunchParams(extension_service_->profile(), extension,
                                   extensions::LAUNCH_CONTAINER_WINDOW,
                                   NEW_WINDOW,
                                   extensions::SOURCE_EXTENSIONS_PAGE));
 }
 
-void ExtensionSettingsHandler::HandleReloadMessage(
-    const base::ListValue* args) {
-  std::string extension_id = base::UTF16ToUTF8(ExtractStringValue(args));
-  CHECK(!extension_id.empty());
-  extension_service_->ReloadExtensionWithQuietFailure(extension_id);
-}
-
 void ExtensionSettingsHandler::HandleRepairMessage(
     const base::ListValue* args) {
   std::string extension_id = base::UTF16ToUTF8(ExtractStringValue(args));
   CHECK(!extension_id.empty());
   scoped_refptr<WebstoreReinstaller> reinstaller(new WebstoreReinstaller(
       web_contents(),
       extension_id,
       base::Bind(&ExtensionSettingsHandler::OnReinstallComplete,
                  AsWeakPtr())));
   reinstaller->BeginReinstall();
 }
 
 void ExtensionSettingsHandler::HandleEnableErrorCollectionMessage(
     const base::ListValue* args) {
   CHECK_EQ(2u, args->GetSize());
   std::string extension_id;
   std::string enable_str;
   CHECK(args->GetString(0, &extension_id));
   CHECK(args->GetString(1, &enable_str));
   bool enabled = enable_str == "true";
   ErrorConsole::Get(Profile::FromWebUI(web_ui()))
       ->SetReportingAllForExtension(extension_id, enabled);
 }
 
-void ExtensionSettingsHandler::HandleAllowFileAccessMessage(
-    const base::ListValue* args) {
-  CHECK_EQ(2U, args->GetSize());
-  std::string extension_id, allow_str;
-  CHECK(args->GetString(0, &extension_id));
-  CHECK(args->GetString(1, &allow_str));
-  const Extension* extension =
-      extension_service_->GetInstalledExtension(extension_id);
-  if (!extension)
-    return;
-
-  if (util::IsExtensionSupervised(extension, Profile::FromWebUI(web_ui())))

[not at google - send to devlin, 2015/02/26 00:56:48]

Looks like you lost this check in the move to the developer private API.

[Devlin, 2015/02/26 01:14:03]

I didn't miss it; it wasn't there when I moved it! ;)  (It really wasn't.) 
Added.

-    return;
-
-  if (!management_policy_->UserMayModifySettings(extension, NULL)) {
-    LOG(ERROR) << "An attempt was made to change allow file access of an"
-               << " extension that is non-usermanagable. Extension id : "
-               << extension->id();
-    return;
-  }
-
-  util::SetAllowFileAccess(
-      extension_id, extension_service_->profile(), allow_str == "true");
-}
-
 void ExtensionSettingsHandler::HandleAllowOnAllUrlsMessage(
     const base::ListValue* args) {
   DCHECK(FeatureSwitch::scripts_require_action()->IsEnabled());
   CHECK_EQ(2u, args->GetSize());
   std::string extension_id;
   std::string allow_str;
   CHECK(args->GetString(0, &extension_id));
   CHECK(args->GetString(1, &allow_str));
   util::SetAllowedScriptingOnAllUrls(extension_id,
                                      extension_service_->GetBrowserContext(),
@@ skipping 330 matching lines @@
 }
 
 void ExtensionSettingsHandler::OnReinstallComplete(
     bool success,
     const std::string& error,
     webstore_install::Result result) {
   MaybeUpdateAfterNotification();
 }
 
 }  // namespace extensions