Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 954943004: Remove dependency on //components/feedback on iOS (Closed)

Created:
5 years, 10 months ago by sdefresne
Modified:
5 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency on //components/feedback on iOS iOS does not use //components/feedback to report feedback so remove the unused dependencies. BUG=None Committed: https://crrev.com/3e96329f442c10d73174688a4786ab847a49a37f Cr-Commit-Position: refs/heads/master@{#318211}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -25 lines) Patch
M chrome/browser/BUILD.gn View 3 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 3 chunks +1 line, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 3 chunks +1 line, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 3 chunks +1 line, -2 lines 0 comments Download
M components/BUILD.gn View 3 chunks +1 line, -2 lines 0 comments Download
M components/components.gyp View 1 chunk +1 line, -5 lines 0 comments Download
M components/components_tests.gyp View 6 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sdefresne
Please take a look.
5 years, 10 months ago (2015-02-25 16:21:16 UTC) #2
Nico
lgtm
5 years, 10 months ago (2015-02-25 19:34:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954943004/1
5 years, 10 months ago (2015-02-26 09:36:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-26 09:45:01 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3e96329f442c10d73174688a4786ab847a49a37f Cr-Commit-Position: refs/heads/master@{#318211}
5 years, 10 months ago (2015-02-26 09:45:41 UTC) #7
sdefresne
5 years, 9 months ago (2015-03-02 10:31:51 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/968653004/ by sdefresne@chromium.org.

The reason for reverting is: This CL cause the test to run in another order,
causing a hidden dependency on the ordering to be visible. Reverting as this
cause test failures.

See http://crbug.com/462352.

Powered by Google App Engine
This is Rietveld 408576698