chrome/chrome_browser.gypi - Issue 954943004: Remove dependency on //components/feedback on iOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 954943004: Remove dependency on //components/feedback on iOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 0c5f64a2c78f18b831a03130a44e4f086f77162f..5994b246691d026ad1a1b6c2048dfdf0d2cc0a01 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -2896,7 +2896,6 @@

'../components/components.gyp:enhanced_bookmarks',

'../components/components.gyp:favicon_base',

'../components/components.gyp:favicon_core',

- '../components/components.gyp:feedback_component',

'../components/components.gyp:gcm_driver',

'../components/components.gyp:google_core_browser',

'../components/components.gyp:handoff',

@@ -3367,6 +3366,7 @@

}, { # OS!="android" and OS!="ios"

'sources': [ '<@(chrome_browser_non_mobile_sources)' ],

'dependencies': [

+ '../components/components.gyp:feedback_component',

'../device/core/core.gyp:device_core',

'../device/usb/usb.gyp:device_usb',

]

@@ -3383,7 +3383,6 @@

'chrome_browser_jni_headers',

'dependencies!': [

- '../components/components.gyp:feedback_component',

'../components/components.gyp:storage_monitor',

'../components/components.gyp:web_modal',

'../third_party/libaddressinput/libaddressinput.gyp:libaddressinput',

« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »