Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc

Issue 954943003: [KeyboardEvent] Use DOM |code| rather than Windows-based key code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added missing VKEY in windows for brightness and power Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc
diff --git a/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc b/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc
index c1bfca67fabcc69dd6883cd40e523300e95b8b24..d7eefcbb5e0c6f8c969b4c61d603975303a19772 100644
--- a/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc
+++ b/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc
@@ -18,8 +18,7 @@
#include "ui/events/keycodes/dom3/dom_key.h"
#include "ui/events/keycodes/dom4/keycode_converter.h"
#include "ui/events/keycodes/keyboard_code_conversion.h"
-#include "ui/events/ozone/layout/layout_util.h"
-#include "ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.h"
+#include "ui/events/keycodes/keyboard_code_conversion_xkb.h"
namespace ui {
@@ -29,22 +28,6 @@ typedef base::Callback<void(const std::string&,
scoped_ptr<char, base::FreeDeleter>)>
LoadKeymapCallback;
-DomKey CharacterToDomKey(base::char16 character) {
- switch (character) {
- case 0x08:
- return DomKey::BACKSPACE;
- case 0x09:
- return DomKey::TAB;
- case 0x0A:
- case 0x0D:
- return DomKey::ENTER;
- case 0x1B:
- return DomKey::ESCAPE;
- default:
- return DomKey::CHARACTER;
- }
-}
-
KeyboardCode AlphanumericKeyboardCode(base::char16 character) {
// Plain ASCII letters and digits map directly to VKEY values.
if ((character >= '0') && (character <= '9'))
@@ -766,6 +749,7 @@ bool XkbKeyboardLayoutEngine::Lookup(DomCode dom_code,
*platform_keycode = xkb_keysym;
// Classify the keysym and convert to DOM and VKEY representations.
*dom_key = NonPrintableXkbKeySymToDomKey(xkb_keysym);
+ KeyboardCode keyboard_code = DomCodeToKeyboardCode(dom_code);
if (*dom_key == DomKey::NONE) {
*dom_key = CharacterToDomKey(*character);
*key_code = AlphanumericKeyboardCode(*character);
@@ -773,7 +757,7 @@ bool XkbKeyboardLayoutEngine::Lookup(DomCode dom_code,
*key_code = DifficultKeyboardCode(dom_code, flags, xkb_keycode, xkb_flags,
xkb_keysym, *dom_key, *character);
if (*key_code == VKEY_UNKNOWN)
- *key_code = DomCodeToNonLocatedKeyboardCode(dom_code);
+ *key_code = LocatedToNonLocatedKeyboardCode(keyboard_code);
}
if ((flags & EF_CONTROL_DOWN) == EF_CONTROL_DOWN) {
@@ -783,11 +767,11 @@ bool XkbKeyboardLayoutEngine::Lookup(DomCode dom_code,
}
} else if (*dom_key == DomKey::DEAD) {
*character = DeadXkbKeySymToCombiningCharacter(xkb_keysym);
- *key_code = DomCodeToNonLocatedKeyboardCode(dom_code);
+ *key_code = LocatedToNonLocatedKeyboardCode(keyboard_code);
} else {
*key_code = NonPrintableDomKeyToKeyboardCode(*dom_key);
if (*key_code == VKEY_UNKNOWN)
- *key_code = DomCodeToNonLocatedKeyboardCode(dom_code);
+ *key_code = LocatedToNonLocatedKeyboardCode(keyboard_code);
}
return true;
}

Powered by Google App Engine
This is Rietveld 408576698