ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h - Issue 954943003: [KeyboardEvent] Use DOM |code| rather than Windows-based key code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h

Issue 954943003: [KeyboardEvent] Use DOM |code| rather than Windows-based key code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added missing VKEY in windows for brightness and power Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc ('k') | ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h

diff --git a/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h b/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h

index 382a9d3f6f880d1b95c51ac1756307ec8cc09fd1..67cb05a0d2e56f6d2d7c20a12f0bbe0f74a55028 100644

--- a/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h

+++ b/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h

@@ -58,7 +58,7 @@ class EVENTS_OZONE_LAYOUT_EXPORT XkbKeyboardLayoutEngine

// Determines the Windows-based KeyboardCode (VKEY) for a character key,

// accounting for non-US layouts. May return VKEY_UNKNOWN, in which case the

- // caller should use |DomCodeToNonLocatedKeyboardCode()| as a last resort.

+ // caller should use |LocatedToNonLocatedKeyboardCode()| as a last resort.

KeyboardCode DifficultKeyboardCode(DomCode dom_code,

int ui_flags,

xkb_keycode_t xkb_keycode,