Issue 954923004: Kill off unused IFXJS interface methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 954923004: Kill off unused IFXJS interface methods. (Closed)

Created:
5 years, 10 months ago by Tom Sepez

Modified:
5 years, 10 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Kill off unused IFXJS interface methods. Re-work of original CL at: https://codereview.chromium.org/933043002/ Much of the IFXJS interface appears completely unused, so Kill off unused IFXJS interface methods. The code itself appears incomplete against all of the objects present in the paths that actually do register objects with JS. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/57e4c86145a247915c59ae5130cfc3ef9b36aa4c

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -204 lines)			Patch
M	fpdfsdk/include/javascript/IJavaScript.h	View	1 chunk	+1 line, -10 lines	0 comments	Download
M	fpdfsdk/include/javascript/JS_Define.h	View	6 chunks	+0 lines, -42 lines	0 comments	Download
M	fpdfsdk/include/javascript/JS_Runtime.h	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Runtime.cpp	View	1 chunk	+0 lines, -143 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

5 years, 10 months ago (2015-02-25 22:38:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
57e4c86145a247915c59ae5130cfc3ef9b36aa4c (presubmit successful).