Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 933043002: Kill off unused IFXJS interface methods. (Closed)

Created:
5 years, 10 months ago by Tom Sepez
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang, jun_fang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Moved to https://codereview.chromium.org/954923004/ Kill off unused IFXJS interface methods. Much of the IFXJS interface appears completely unused, so Kill off unused IFXJS interface methods. The code itself appears incomplete against all of the objects present in the paths that actually do register objects with JS.

Patch Set 1 #

Patch Set 2 : More unused code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -200 lines) Patch
M fpdfsdk/include/javascript/IJavaScript.h View 1 1 chunk +0 lines, -8 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Define.h View 6 chunks +0 lines, -42 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Runtime.h View 1 1 chunk +0 lines, -9 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 1 1 chunk +0 lines, -141 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
Tom Sepez
Jun, could you take a look at this and run it by your developers? I ...
5 years, 10 months ago (2015-02-18 18:23:34 UTC) #2
jun_fang
On 2015/02/18 18:23:34, Tom Sepez wrote: > Jun, could you take a look at this ...
5 years, 10 months ago (2015-02-19 23:16:56 UTC) #3
Tom Sepez
On 2015/02/19 23:16:56, jun_fang wrote: > On 2015/02/18 18:23:34, Tom Sepez wrote: > > Jun, ...
5 years, 10 months ago (2015-02-20 00:05:48 UTC) #4
jun_fang
On 2015/02/20 00:05:48, Tom Sepez wrote: > On 2015/02/19 23:16:56, jun_fang wrote: > > On ...
5 years, 10 months ago (2015-02-20 00:20:26 UTC) #5
Tom Sepez
Lei, I should probably have CC'd you on this as well.
5 years, 10 months ago (2015-02-24 23:16:30 UTC) #7
Lei Zhang
Should we remove this on the main branch too?
5 years, 10 months ago (2015-02-25 20:10:56 UTC) #8
Tom Sepez
On 2015/02/25 20:10:56, Lei Zhang wrote: > Should we remove this on the main branch ...
5 years, 10 months ago (2015-02-25 22:15:14 UTC) #9
Lei Zhang
On 2015/02/25 22:15:14, Tom Sepez wrote: > On 2015/02/25 20:10:56, Lei Zhang wrote: > > ...
5 years, 10 months ago (2015-02-25 22:17:04 UTC) #10
Tom Sepez
On 2015/02/25 22:17:04, Lei Zhang wrote: > On 2015/02/25 22:15:14, Tom Sepez wrote: > > ...
5 years, 10 months ago (2015-02-25 22:19:37 UTC) #11
jun_fang
5 years, 9 months ago (2015-03-02 15:36:42 UTC) #12
Message was sent while issue was closed.
On 2015/02/25 22:19:37, Tom Sepez wrote:
> On 2015/02/25 22:17:04, Lei Zhang wrote:
> > On 2015/02/25 22:15:14, Tom Sepez wrote:
> > > On 2015/02/25 20:10:56, Lei Zhang wrote:
> > > > Should we remove this on the main branch too?
> > > Yes.  I made the initial hack at this on XFA, figuring if XFA doesn't need
> it,
> > > then main doesn't either.
> > 
> > Can we make the change on the main branch first and then merge to XFA, which
> is
> > what we do most of the time.
> Sure.  No problem.  I'll upload a new CL.

Confirmed with our developers, it's fine to remove unused IFXJS interface
methods.

Powered by Google App Engine
This is Rietveld 408576698