Issue 954893002: Add support for VIEW intents to SkyShell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 954893002: Add support for VIEW intents to SkyShell. (Closed)

Created:
5 years, 10 months ago by eseidel

Modified:
5 years, 10 months ago

Reviewers:
abarth-chromium

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add support for VIEW intents to SkyShell. This was landed on the skyshell branch and I forgot to pull it over: https://codereview.chromium.org/946583003 TBR=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2a784c01b81ae73800ed229508a69cbed193a8e4

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -8 lines)			Patch
M	sky/services/viewport/viewport_observer.mojom	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/shell/apk/AndroidManifest.xml	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	sky/shell/apk/src/org/domokit/sky/shell/PlatformView.java	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	sky/shell/apk/src/org/domokit/sky/shell/SkyShellActivity.java	View	2 chunks	+13 lines, -1 line	0 comments	Download
M	sky/shell/ui/engine.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	sky/shell/ui/engine.cc	View	3 chunks	+16 lines, -7 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

eseidel

5 years, 10 months ago (2015-02-25 01:39:40 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2a784c01b81ae73800ed229508a69cbed193a8e4 (presubmit successful).

Expand Messages | Collapse Messages