Issue 946583003: Teach SkyShell how to listen for VIEW intents of sky: urls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 946583003: Teach SkyShell how to listen for VIEW intents of sky: urls. (Closed)

Created:
5 years, 10 months ago by eseidel

Modified:
5 years, 10 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:abarth/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Teach SkyShell how to listen for VIEW intents of sky: urls. For example, this will launch sky now: adb shell am start -a "android.intent.action.VIEW" -d "sky:domokit.github.io/sky/examples/spinning-square.sky" R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/86303ddd801261dd4d82ec3dd458bcdf4f928515

Patch Set 1 #

Total comments: 2

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -8 lines)			Patch
M	sky/services/viewport/viewport_observer.mojom	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/shell/apk/AndroidManifest.xml	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	sky/shell/apk/src/org/domokit/sky/shell/PlatformView.java	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	sky/shell/apk/src/org/domokit/sky/shell/SkyShellActivity.java	View	2 chunks	+13 lines, -1 line	0 comments	Download
M	sky/shell/ui/engine.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	sky/shell/ui/engine.cc	View	3 chunks	+16 lines, -7 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

lgtm https://codereview.chromium.org/946583003/diff/1/sky/shell/ui/engine.cc File sky/shell/ui/engine.cc (right): https://codereview.chromium.org/946583003/diff/1/sky/shell/ui/engine.cc#newcode79 sky/shell/ui/engine.cc:79: { Chromium style is to combine these lines. ...

5 years, 10 months ago (2015-02-20 22:10:49 UTC) #2

eseidel

5 years, 10 months ago (2015-02-20 22:16:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
86303ddd801261dd4d82ec3dd458bcdf4f928515 (presubmit successful).

Expand Messages | Collapse Messages