Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 954733002: Update gyp/gn files after header moved from webkit to cc/blink. (Closed)

Created:
5 years, 9 months ago by Daniel Bratell
Modified:
5 years, 9 months ago
Reviewers:
jamesr, piman, tfarina
CC:
chromium-reviews, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update gyp/gn files after header moved from webkit to cc/blink. Followup to https://codereview.chromium.org/890873007 which moves webkit/common/gpu/context_provider_web_context.h to cc/blink/context_provider_web_context.h. R=tfarina@chromium.org,jamesr@chromium.org,piman@chromium.org BUG=459058, 338338 Committed: https://crrev.com/af2fe9ec1f79c2530e0188a35b0cd1a7ed6d646f Cr-Commit-Position: refs/heads/master@{#318017}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M cc/blink/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M cc/blink/cc_blink.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/common/gpu/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/common/gpu/webkit_gpu.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Daniel Bratell
5 years, 9 months ago (2015-02-24 15:47:55 UTC) #1
tfarina
lgtm
5 years, 9 months ago (2015-02-24 15:59:33 UTC) #2
piman
lgtm
5 years, 9 months ago (2015-02-24 21:47:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954733002/1
5 years, 9 months ago (2015-02-25 09:27:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-25 10:33:33 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-02-25 10:34:51 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/af2fe9ec1f79c2530e0188a35b0cd1a7ed6d646f
Cr-Commit-Position: refs/heads/master@{#318017}

Powered by Google App Engine
This is Rietveld 408576698