Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2604)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 890873007: Cleanup: Move ContextProviderWebContext into cc/blink. (Closed)

Created:
5 years, 10 months ago by tfarina
Modified:
5 years, 10 months ago
Reviewers:
jamesr, piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, posciak+watch_chromium.org, nasko+codewatch_chromium.org, jam, mcasas+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, wjia+watch_chromium.org, danakj+watch_chromium.org, Avi (use Gerrit), boliu, danakj, darin (slow to review), enne (OOO), jochen (gone - plz use gerrit), pilgrim_google
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Move ContextProviderWebContext into cc/blink. This is one of the steps needed to move ContextProviderInProcess to android_webview. BUG=338338 R=jamesr@chromium.org,piman@chromium.org Committed: https://crrev.com/ae8232dfef2a097fef675e4ec855c1a65e9f7a82 Cr-Commit-Position: refs/heads/master@{#314552}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -90 lines) Patch
A + cc/blink/context_provider_web_context.h View 2 chunks +5 lines, -7 lines 0 comments Download
M content/browser/android/in_process/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_factory_impl.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/gpu/client/context_provider_command_buffer.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/android/synchronous_compositor_factory.h View 2 chunks +8 lines, -10 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/pepper/video_decoder_shim.h View 3 chunks +5 lines, -7 lines 0 comments Download
M content/renderer/pepper/video_decoder_shim.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.h View 4 chunks +7 lines, -10 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/webgraphicscontext3d_provider_impl.h View 3 chunks +4 lines, -6 lines 0 comments Download
M content/renderer/webgraphicscontext3d_provider_impl.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M webkit/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/common/gpu/context_provider_in_process.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/common/gpu/context_provider_in_process.cc View 1 chunk +0 lines, -2 lines 0 comments Download
D webkit/common/gpu/context_provider_web_context.h View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
tfarina
PTAL
5 years, 10 months ago (2015-01-31 01:52:08 UTC) #1
jamesr
cc/blink/ and webkit/ lgtm
5 years, 10 months ago (2015-01-31 02:07:14 UTC) #2
piman
lgtm
5 years, 10 months ago (2015-02-03 21:33:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890873007/1
5 years, 10 months ago (2015-02-04 13:07:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 13:10:31 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 13:11:29 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ae8232dfef2a097fef675e4ec855c1a65e9f7a82
Cr-Commit-Position: refs/heads/master@{#314552}

Powered by Google App Engine
This is Rietveld 408576698