Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: Source/bindings/tests/results/core/V8TestObject.cpp

Issue 954723002: [bindings] Support is_explicit_nullable for method arguments. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Review comments addressed! Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8TestObject.cpp
diff --git a/Source/bindings/tests/results/core/V8TestObject.cpp b/Source/bindings/tests/results/core/V8TestObject.cpp
index aa9558be16a7915839bc4d40ca1bea4e646f4f0d..7235f4e0dbb42a1759ddeaff1a8650f84c0495d2 100644
--- a/Source/bindings/tests/results/core/V8TestObject.cpp
+++ b/Source/bindings/tests/results/core/V8TestObject.cpp
@@ -6215,7 +6215,7 @@ static void voidMethodNullableVoidCallbackFunctionArgMethod(const v8::FunctionCa
return;
}
TestObject* impl = V8TestObject::toImpl(info.Holder());
- ScriptValue voidCallbackFunctionArg;
+ Nullable<ScriptValue> voidCallbackFunctionArg;
Jens Widell 2015/03/02 07:53:13 This is wrong; ScriptValue can store null, so shou
{
if (!info[0]->IsFunction() && !info[0]->IsNull()) {
V8ThrowException::throwTypeError(info.GetIsolate(), ExceptionMessages::failedToExecute("voidMethodNullableVoidCallbackFunctionArg", "TestObject", "The callback provided as parameter 1 is not a function."));

Powered by Google App Engine
This is Rietveld 408576698