Source/bindings/tests/idls/core/TestInterface.idl - Issue 954723002: [bindings] Support is_explicit_nullable for method arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/idls/core/TestInterface.idl

Issue 954723002: [bindings] Support is_explicit_nullable for method arguments. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review comments addressed! Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/templates/methods.cpp ('K') | « Source/bindings/templates/methods.cpp ('k') | Source/bindings/tests/results/core/V8TestInterface.cpp » ('j') | Source/bindings/tests/results/core/V8TestObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/idls/core/TestInterface.idl

diff --git a/Source/bindings/tests/idls/core/TestInterface.idl b/Source/bindings/tests/idls/core/TestInterface.idl

index 4c945efa43f1a9aa2a6c9d6e7c321801079f562b..bcd10fd35525ed9fc7a0833a4034f8c3a1f7278c 100644

--- a/Source/bindings/tests/idls/core/TestInterface.idl

+++ b/Source/bindings/tests/idls/core/TestInterface.idl

@@ -106,6 +106,7 @@

Promise promiseMethodPartialOverload();

Promise promiseMethodPartialOverload(Window window);

static Promise staticPromiseMethodPartialOverload();

+ void methodWithExplicitNullableArgument(optional object[]? arguments);

Jens Widell 2015/03/02 07:53:13 I think this rather belongs in TestObject.idl, whe

};

TestInterface implements TestImplements;