Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 954373003: Add transition animations to thumbnail updates in list view. (Closed)

Created:
5 years, 10 months ago by yawano
Modified:
5 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add transition animations to thumbnail updates in list view. BUG=456016 TEST=manually tested; Edit some file in list view and see the thumbnail is updated with transition animation. Committed: https://crrev.com/ae645f0e259c5af4681209429c814c0573a4a87e Cr-Commit-Position: refs/heads/master@{#318679}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Fix to pass presubmit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -15 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 2 2 chunks +25 lines, -8 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_grid.js View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_table.js View 1 3 chunks +27 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
yawano
PTAL. Thank you!
5 years, 10 months ago (2015-02-26 09:15:33 UTC) #2
fukino
On 2015/02/26 09:15:33, yawano wrote: > PTAL. Thank you! https://codereview.chromium.org/962103002/ has landed, which will make ...
5 years, 9 months ago (2015-03-02 08:19:52 UTC) #3
yawano
Rebased the CL. PTAL. Thank you!
5 years, 9 months ago (2015-03-02 09:16:38 UTC) #4
fukino
lgtm. Thank you!
5 years, 9 months ago (2015-03-02 10:01:01 UTC) #5
yawano
On 2015/03/02 10:01:01, fukino wrote: > lgtm. Thank you! Thank you!
5 years, 9 months ago (2015-03-02 10:01:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954373003/20001
5 years, 9 months ago (2015-03-02 10:07:40 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/46557)
5 years, 9 months ago (2015-03-02 10:21:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954373003/40001
5 years, 9 months ago (2015-03-02 10:59:00 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-02 11:33:00 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 11:33:27 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ae645f0e259c5af4681209429c814c0573a4a87e
Cr-Commit-Position: refs/heads/master@{#318679}

Powered by Google App Engine
This is Rietveld 408576698