ui/file_manager/file_manager/foreground/js/ui/file_grid.js - Issue 954373003: Add transition animations to thumbnail updates in list view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/ui/file_grid.js

Issue 954373003: Add transition animations to thumbnail updates in list view. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix to pass presubmit. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/css/file_manager.css ('k') | ui/file_manager/file_manager/foreground/js/ui/file_table.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/ui/file_grid.js

diff --git a/ui/file_manager/file_manager/foreground/js/ui/file_grid.js b/ui/file_manager/file_manager/foreground/js/ui/file_grid.js

index db001f078038eca50e5ad20caf488987df4eac70..e680ed21129f125687f3b512bf2ac86edce615a2 100644

--- a/ui/file_manager/file_manager/foreground/js/ui/file_grid.js

+++ b/ui/file_manager/file_manager/foreground/js/ui/file_grid.js

@@ -279,7 +279,7 @@ FileGrid.setThumbnailImage_ = function(box, dataUrl, shouldAnimate) {

thumbnail.style.backgroundImage = 'url(' + dataUrl + ')';

thumbnail.addEventListener('webkitAnimationEnd', function() {

// Remove animation css once animation is completed in order not to animate

- // agein when an item is attached to the dom again.

+ // again when an item is attached to the dom again.

thumbnail.classList.remove('animate');

for (var i = 0; i < oldThumbnails.length; i++) {