Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 954363003: Android: Don't set the current minutes to the minutes field of <input type=time> dialog. (Closed)

Created:
5 years, 9 months ago by tkent
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Don't set the current minutes to the minutes field of <input type=time step=3600> dialog. For <input type=time step=3600>, the minutes field should be disabled, and the value should be the minutes of the minimum value, not the current time. (Actually, it should be the minutes of the step-base value. This CL adds TODO() for it.) Also, this CL fixes a bug for step>3600. <input type=time step=5400> should not disable the minutes field. BUG=409791 Committed: https://crrev.com/f265c25756366f90cebc39d1cbaba410e0842a23 Cr-Commit-Position: refs/heads/master@{#318747}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M ui/android/java/src/org/chromium/ui/picker/MultiFieldTimePickerDialog.java View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
tkent
aurimas@, would you review this please? I wanted to add a test, but it's very ...
5 years, 9 months ago (2015-03-02 08:49:42 UTC) #2
aurimas (slooooooooow)
lgtm
5 years, 9 months ago (2015-03-02 18:59:46 UTC) #3
aurimas (slooooooooow)
+anton as FYI
5 years, 9 months ago (2015-03-02 19:17:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954363003/1
5 years, 9 months ago (2015-03-02 20:11:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-02 21:03:02 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 21:04:14 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f265c25756366f90cebc39d1cbaba410e0842a23
Cr-Commit-Position: refs/heads/master@{#318747}

Powered by Google App Engine
This is Rietveld 408576698