Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: ui/android/java/src/org/chromium/ui/picker/MultiFieldTimePickerDialog.java

Issue 954363003: Android: Don't set the current minutes to the minutes field of <input type=time> dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/android/java/src/org/chromium/ui/picker/MultiFieldTimePickerDialog.java
diff --git a/ui/android/java/src/org/chromium/ui/picker/MultiFieldTimePickerDialog.java b/ui/android/java/src/org/chromium/ui/picker/MultiFieldTimePickerDialog.java
index d03c16509f87a6a523fb2e83b469b8108296a395..f8647ec24d2d9e0811b1cea542154f6bd8bbf8fb 100644
--- a/ui/android/java/src/org/chromium/ui/picker/MultiFieldTimePickerDialog.java
+++ b/ui/android/java/src/org/chromium/ui/picker/MultiFieldTimePickerDialog.java
@@ -155,11 +155,14 @@ public class MultiFieldTimePickerDialog
mMinuteSpinner.setMaxValue(59);
}
- if (step >= HOUR_IN_MILLIS) {
+ mMinuteSpinner.setValue(minute);
+ if (step % HOUR_IN_MILLIS == 0) {
mMinuteSpinner.setEnabled(false);
+ // TODO(tkent): We should set minutes value of
+ // WebDateTimeChooserParams::stepBase.
+ mMinuteSpinner.setValue(minMinute);
}
- mMinuteSpinner.setValue(minute);
mMinuteSpinner.setFormatter(twoDigitPaddingFormatter);
if (step >= MINUTE_IN_MILLIS) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698