Routes WindowManager functionality through the view manager

Routes WindowManager functionality through the view manager

This is an ugly hack, but necessary until we have the ability to have
message ordering for multiple pipes.

BUG=460621
R=msw@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/6edabbf44d507b6d921d22997b33c62c893e634e

[msw, 2015-02-25 22:29:30]

lgtm with nits. You should probably include BUG=461388 too.

https://codereview.chromium.org/954273002/diff/1/mojo/services/view_manager/p...
File mojo/services/view_manager/public/cpp/view_manager_delegate.h (right):

https://codereview.chromium.org/954273002/diff/1/mojo/services/view_manager/p...
mojo/services/view_manager/public/cpp/view_manager_delegate.h:43: // TODO(sky):
nuke! See comments in view_manager.mojom for details.n
nit: remove trailing 'n'

https://codereview.chromium.org/954273002/diff/1/mojo/services/view_manager/p...
File mojo/services/view_manager/public/interfaces/view_manager.mojom (right):

https://codereview.chromium.org/954273002/diff/1/mojo/services/view_manager/p...
mojo/services/view_manager/public/interfaces/view_manager.mojom:226: // Invoked
solely on the windowmanager. See comments in PerformAction() above
nit: "window manager" or "WindowManager"?

https://codereview.chromium.org/954273002/diff/1/services/window_manager/wind...
File services/window_manager/window_manager_app.cc (right):

https://codereview.chromium.org/954273002/diff/1/services/window_manager/wind...
services/window_manager/window_manager_app.cc:185: void
WindowManagerApp::OnPerformAction(mojo::View* view,
nit: match the function definition order of this "ViewManagerDelegate
implementation" section with the declarations in the header.

https://codereview.chromium.org/954273002/diff/1/services/window_manager/wind...
File services/window_manager/window_manager_app.h (right):

https://codereview.chromium.org/954273002/diff/1/services/window_manager/wind...
services/window_manager/window_manager_app.h:112: bool SetCapture(mojo::View*
view);
nit: consider "SetCaptureImpl" here, etc. below, to avoid name overloads.

[msw, 2015-02-25 22:30:32]

https://codereview.chromium.org/954273002/diff/1/services/view_manager/view_m...
File services/view_manager/view_manager_service_impl.cc (right):

https://codereview.chromium.org/954273002/diff/1/services/view_manager/view_m...
services/view_manager/view_manager_service_impl.cc:633: const
mojo::Callback<void(bool)>& callback) {
Oh, hmm, should this callback be run when the wm responds?

[sky, 2015-02-25 23:20:27]

Updated. Did you want to take another look?

https://codereview.chromium.org/954273002/diff/1/mojo/services/view_manager/p...
File mojo/services/view_manager/public/cpp/view_manager_delegate.h (right):

https://codereview.chromium.org/954273002/diff/1/mojo/services/view_manager/p...
mojo/services/view_manager/public/cpp/view_manager_delegate.h:43: // TODO(sky):
nuke! See comments in view_manager.mojom for details.n
On 2015/02/25 22:29:30, msw wrote:
> nit: remove trailing 'n'

Done.

https://codereview.chromium.org/954273002/diff/1/mojo/services/view_manager/p...
File mojo/services/view_manager/public/interfaces/view_manager.mojom (right):

https://codereview.chromium.org/954273002/diff/1/mojo/services/view_manager/p...
mojo/services/view_manager/public/interfaces/view_manager.mojom:226: // Invoked
solely on the windowmanager. See comments in PerformAction() above
On 2015/02/25 22:29:30, msw wrote:
> nit: "window manager" or "WindowManager"?

Done.

https://codereview.chromium.org/954273002/diff/1/services/view_manager/view_m...
File services/view_manager/view_manager_service_impl.cc (right):

https://codereview.chromium.org/954273002/diff/1/services/view_manager/view_m...
services/view_manager/view_manager_service_impl.cc:633: const
mojo::Callback<void(bool)>& callback) {
On 2015/02/25 22:30:32, msw wrote:
> Oh, hmm, should this callback be run when the wm responds?

Done.

https://codereview.chromium.org/954273002/diff/1/services/window_manager/wind...
File services/window_manager/window_manager_app.cc (right):

https://codereview.chromium.org/954273002/diff/1/services/window_manager/wind...
services/window_manager/window_manager_app.cc:185: void
WindowManagerApp::OnPerformAction(mojo::View* view,
On 2015/02/25 22:29:30, msw wrote:
> nit: match the function definition order of this "ViewManagerDelegate
> implementation" section with the declarations in the header.

The order here and in the header is consistent, but overall .cc is out of order
with the .h. I'll fix that separately.

https://codereview.chromium.org/954273002/diff/1/services/window_manager/wind...
File services/window_manager/window_manager_app.h (right):

https://codereview.chromium.org/954273002/diff/1/services/window_manager/wind...
services/window_manager/window_manager_app.h:112: bool SetCapture(mojo::View*
view);
On 2015/02/25 22:29:30, msw wrote:
> nit: consider "SetCaptureImpl" here, etc. below, to avoid name overloads.

Done.

[msw, 2015-02-25 23:56:59]

lgtm

[sky, 2015-02-26 00:02:54]

Committed patchset #2 (id:20001) manually as
6edabbf44d507b6d921d22997b33c62c893e634e (presubmit successful).