services/view_manager/view_manager_client_apptest.cc - Issue 954273002: Routes WindowManager functionality through the view manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/view_manager/view_manager_client_apptest.cc

Issue 954273002: Routes WindowManager functionality through the view manager (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/view_manager/view_manager_client_apptest.cc

diff --git a/services/view_manager/view_manager_client_apptest.cc b/services/view_manager/view_manager_client_apptest.cc

index eed4391c42c9aca756e9f4975732c5039acc3eb8..82e255063c2f026cf30b19eebb0ac156a8310351 100644

--- a/services/view_manager/view_manager_client_apptest.cc

+++ b/services/view_manager/view_manager_client_apptest.cc

@@ -581,9 +581,7 @@ class FocusChangeObserver : public ViewObserver {

} // namespace

-// TODO(msw|alhaad|sky): Fix underlying flakiness here. http://crbug.com/460621

-TEST_F(ViewManagerTest, DISABLED_Focus) {

+TEST_F(ViewManagerTest, Focus) {

View* view1 = window_manager()->CreateView();

view1->SetVisible(true);

window_manager()->GetRoot()->AddChild(view1);