Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 954163002: Add woff2 to src/third_party (Closed)

Created:
5 years, 10 months ago by Kunihiko Sakamoto
Modified:
5 years, 9 months ago
Reviewers:
open-source-third-party-reviews, cpu_(ooo_6.6-7.5), security, bashi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add woff2 to src/third_party This patch adds the woff2 library [1] which is used to decode WOFF 2.0 web font file format. It's going to replace the old version of WOFF 2.0 decoder included in third_party/ots. [1] https://github.com/google/woff2 (revision 445f5419) BUG=434596 TEST=trybots Committed: https://crrev.com/ca9922675a84f05f3e33b38ad74875d1b84772db Cr-Commit-Position: refs/heads/master@{#322517}

Patch Set 1 : #

Patch Set 2 : rebase as third_party/ots/src/woff2.cc has changed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3469 lines, --2 lines) Patch
A third_party/woff2/.gitignore View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/woff2/BUILD.gn View 1 chunk +33 lines, -0 lines 0 comments Download
A + third_party/woff2/LICENSE View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/woff2/Makefile View 1 chunk +42 lines, -0 lines 0 comments Download
A + third_party/woff2/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/woff2/README.chromium View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/woff2/README.md View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/woff2/src/buffer.h View 1 chunk +172 lines, -0 lines 0 comments Download
A third_party/woff2/src/file.h View 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/woff2/src/font.h View 1 chunk +82 lines, -0 lines 0 comments Download
A third_party/woff2/src/font.cc View 1 chunk +198 lines, -0 lines 0 comments Download
A third_party/woff2/src/glyph.h View 1 chunk +71 lines, -0 lines 0 comments Download
A third_party/woff2/src/glyph.cc View 1 chunk +380 lines, -0 lines 0 comments Download
A third_party/woff2/src/normalize.h View 1 chunk +45 lines, -0 lines 0 comments Download
A third_party/woff2/src/normalize.cc View 1 chunk +253 lines, -0 lines 0 comments Download
A third_party/woff2/src/port.h View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/woff2/src/round.h View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/woff2/src/store_bytes.h View 1 chunk +61 lines, -0 lines 0 comments Download
A third_party/woff2/src/table_tags.h View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/woff2/src/table_tags.cc View 1 chunk +90 lines, -0 lines 0 comments Download
A third_party/woff2/src/transform.h View 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/woff2/src/transform.cc View 1 chunk +270 lines, -0 lines 0 comments Download
A third_party/woff2/src/woff2_common.h View 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/woff2/src/woff2_compress.cc View 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/woff2/src/woff2_dec.h View 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/woff2/src/woff2_dec.cc View 1 1 chunk +901 lines, -0 lines 0 comments Download
A third_party/woff2/src/woff2_decompress.cc View 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/woff2/src/woff2_enc.h View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/woff2/src/woff2_enc.cc View 1 chunk +346 lines, -0 lines 0 comments Download
A third_party/woff2/woff2.gyp View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
Kunihiko Sakamoto
5 years, 9 months ago (2015-03-06 05:55:36 UTC) #6
bashi
Rubber-stamp LGTM. Could you mention URL/revision in the description? It would be helpful when we ...
5 years, 9 months ago (2015-03-06 06:06:00 UTC) #7
Kunihiko Sakamoto
> Could you mention URL/revision in the description? It would be helpful when we > ...
5 years, 9 months ago (2015-03-06 06:09:36 UTC) #8
cpu_(ooo_6.6-7.5)
please follow the steps at http://www.chromium.org/developers/adding-3rd-party-libraries in your case we need both the open source ...
5 years, 9 months ago (2015-03-09 20:45:18 UTC) #9
Kunihiko Sakamoto
Thanks for the heads up. Sent review requests to those lists.
5 years, 9 months ago (2015-03-10 06:06:36 UTC) #10
Kunihiko Sakamoto
Hi cpu@, we got approvals from open-source-third-party-reviews@ and security@ (on the mailing lists). Could you ...
5 years, 9 months ago (2015-03-20 01:09:03 UTC) #11
Kunihiko Sakamoto
Ping, in case you missed the last update :)
5 years, 9 months ago (2015-03-26 05:28:34 UTC) #12
cpu_(ooo_6.6-7.5)
lgtm
5 years, 9 months ago (2015-03-26 20:20:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954163002/80001
5 years, 9 months ago (2015-03-27 00:42:38 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/37158) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 9 months ago (2015-03-27 00:46:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954163002/100001
5 years, 9 months ago (2015-03-27 01:00:39 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:100001)
5 years, 9 months ago (2015-03-27 01:31:06 UTC) #21
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 01:32:20 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ca9922675a84f05f3e33b38ad74875d1b84772db
Cr-Commit-Position: refs/heads/master@{#322517}

Powered by Google App Engine
This is Rietveld 408576698