Compile shader upon deletion if attached.

gpu/command_buffer/service/gles2_cmd_decoder.cc

Index: gpu/command_buffer/service/gles2_cmd_decoder.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index 6b254e0966bb8ad2de4ee746bf53e6f7cb3dc269..60006f9c2008764e612092aa1a73f4c24596f44a 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -5133,8 +5133,8 @@ error::Error GLES2DecoderImpl::HandleDeleteShader(uint32 immediate_data_size,
     Shader* shader = GetShader(client_id);
     if (shader) {
       if (!shader->IsDeleted()) {
-        glDeleteShader(shader->service_id());
         shader_manager()->MarkAsDeleted(shader);
+        glDeleteShader(shader->service_id());

[Ken Russell (switch to Gerrit), 2015/02/25 01:10:03]

This won't work. The service_id will have been zeroed out and we won't actually
delete the underlying shader object. This is probably currently generating an
INVALID_VALUE error. Please test for that. We should also ensure that the
command decoder tests will catch the situation where we accidentally leak the
shader object as is currently being done here.

[Zhenyao Mo, 2015/02/25 01:15:37]

You could probably change MarkAsDeleted() to just Delete(), which combines both
the current MarkAsDeleted() and the actual glDeleteShader() call.

[David Yen, 2015/02/25 02:15:00]

Done. This is already being tested but I didn't run gpu_unittests locally.

       }
     } else {
       LOCAL_SET_GL_ERROR(GL_INVALID_VALUE, "glDeleteShader", "unknown shader");