gpu/command_buffer/service/shader_manager.cc - Issue 954073002: Compile shader upon deletion if attached.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/shader_manager.cc

Issue 954073002: Compile shader upon deletion if attached. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added unit test Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/shader_manager.cc

diff --git a/gpu/command_buffer/service/shader_manager.cc b/gpu/command_buffer/service/shader_manager.cc

index d88a628874ab44fd25e9cc844e60d3ce48a8e884..5b735ac3e78ac453499eec8c8a3790a979f8799a 100644

--- a/gpu/command_buffer/service/shader_manager.cc

+++ b/gpu/command_buffer/service/shader_manager.cc

@@ -134,6 +134,10 @@ void Shader::DecUseCount() {

}

void Shader::MarkAsDeleted() {

+ if (use_count_ > 0) {

+ // If attached, compile the shader before we delete it.

+ DoCompile();

+ }

DCHECK_NE(service_id_, 0u);

service_id_ = 0;

}