Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 95403006: x11: Cleanup how valuators are set for X events in tests. (Closed)

Created:
7 years ago by sadrul
Modified:
7 years ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, sky
Visibility:
Public.

Description

x11: Cleanup how valuators are set for X events in tests. BUG=none R=derat@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238264

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 4

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -120 lines) Patch
M ui/aura/root_window_host_x11_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/events/test/events_test_utils_x11.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M ui/events/test/events_test_utils_x11.cc View 1 2 3 5 chunks +30 lines, -70 lines 0 comments Download
M ui/events/x/device_data_manager.h View 1 2 chunks +15 lines, -15 lines 0 comments Download
M ui/events/x/device_data_manager.cc View 2 chunks +45 lines, -31 lines 0 comments Download
M ui/events/x/events_x_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sadrul
7 years ago (2013-11-29 21:27:07 UTC) #1
sadrul
sky@ -> derat@ to ease the review burden.
7 years ago (2013-12-02 21:20:05 UTC) #2
Daniel Erat
https://codereview.chromium.org/95403006/diff/40001/ash/wm/sticky_keys_unittest.cc File ash/wm/sticky_keys_unittest.cc (right): https://codereview.chromium.org/95403006/diff/40001/ash/wm/sticky_keys_unittest.cc#newcode505 ash/wm/sticky_keys_unittest.cc:505: ui::SetupScrollDeviceForTest(kScrollDeviceId); "SetUp" was correct. see e.g. http://notaverb.com/setup https://codereview.chromium.org/95403006/diff/40001/ui/events/test/events_test_utils_x11.h File ...
7 years ago (2013-12-02 21:29:10 UTC) #3
sadrul
https://codereview.chromium.org/95403006/diff/40001/ash/wm/sticky_keys_unittest.cc File ash/wm/sticky_keys_unittest.cc (right): https://codereview.chromium.org/95403006/diff/40001/ash/wm/sticky_keys_unittest.cc#newcode505 ash/wm/sticky_keys_unittest.cc:505: ui::SetupScrollDeviceForTest(kScrollDeviceId); On 2013/12/02 21:29:10, Daniel Erat wrote: > "SetUp" ...
7 years ago (2013-12-02 21:49:49 UTC) #4
Daniel Erat
lgtm
7 years ago (2013-12-02 22:06:30 UTC) #5
sadrul
7 years ago (2013-12-03 01:32:57 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 manually as r238264 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698