Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 954003002: Revert of xp: copy dbghelp.dll to output dir and have base.isolate use it there (Closed)

Created:
5 years, 10 months ago by scottmg
Modified:
5 years, 10 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of xp: copy dbghelp.dll to output dir and have base.isolate use it there (patchset #6 id:100001 of https://codereview.chromium.org/951083003/) Reason for revert: some blink waterfall failing for reasons unclear. dependency on base.isolate without depending on base maybe? Original issue's description: > xp: copy dbghelp.dll to output dir and have base.isolate use it there > > Previous CL https://codereview.chromium.org/943933005 didn't work properly > because the dll wasn't in the same directory as the binary, so it was still > loading the system dbghelp.dll. See details in 460506. > > Copies dbghelp.dll to the output dir, and has the isolate file point at that. > > Re-enable tests that were failing due to dbghelp hanging. > > XP test run here: https://chromium-swarm.appspot.com/user/task/25d5bc17b6dddc10 > > BUG=460506, 461160 > > Committed: https://crrev.com/09acc50cfadc6aa38db23ddadec134410ec968c0 > Cr-Commit-Position: refs/heads/master@{#317868} TBR=cpu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=460506, 461160 Committed: https://crrev.com/9b8a0877ef9a56c31dfd37cc4c335dfd39d51e96 Cr-Commit-Position: refs/heads/master@{#317900}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M base/base.gyp View 1 chunk +0 lines, -8 lines 0 comments Download
M base/base.isolate View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/debugger_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/debug/stack_trace_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M base/process/process_util_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
Created Revert of xp: copy dbghelp.dll to output dir and have base.isolate use it there
5 years, 10 months ago (2015-02-24 22:21:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954003002/1
5 years, 10 months ago (2015-02-24 22:22:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 22:23:40 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 22:24:42 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b8a0877ef9a56c31dfd37cc4c335dfd39d51e96
Cr-Commit-Position: refs/heads/master@{#317900}

Powered by Google App Engine
This is Rietveld 408576698