Issue 943933005: Add dbghelp.dll that works on XP, and include in base.isolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 943933005: Add dbghelp.dll that works on XP, and include in base.isolate (Closed)

Created:
5 years, 10 months ago by scottmg

Modified:
5 years, 10 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Add dbghelp.dll that works on XP, and include in base.isolate This fixes the hang that caused the addition of the early out in stack_trace_win.cc. Removing that in turn fixes symbolization of stack traces on XP bots. R=cpu@chromium.org BUG=460506 Committed: https://chromium.googlesource.com/chromium/src/+/92d69f7733f4028cf8b3d5b4b97a31173e687594

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -4 lines)			Patch
M	base/base.isolate	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	base/debug/stack_trace_win.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
A	build/win/dbghelp_xp/README.chromium	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	build/win/dbghelp_xp/dbghelp.dll	View	Binary file		0 comments	Download

Total messages: 6 (0 generated)

scottmg

Can't use trybots because of binary, so landing manually.

5 years, 10 months ago (2015-02-23 21:13:18 UTC) #4

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/92d69f7733f4028cf8b3d5b4b97a31173e687594 Cr-Commit-Position: refs/heads/master@{#317651}

5 years, 10 months ago (2015-02-23 21:16:08 UTC) #5

scottmg

5 years, 10 months ago (2015-02-23 21:16:24 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
92d69f7733f4028cf8b3d5b4b97a31173e687594 (presubmit successful).