mojo/public/dart/src/data_pipe.dart - Issue 953953003: Introduce dartanalyze into our build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/dart/src/data_pipe.dart

Issue 953953003: Introduce dartanalyze into our build. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Only run dartanalyze on the toplevel check target. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/dart/src/data_pipe.dart

diff --git a/mojo/public/dart/src/data_pipe.dart b/mojo/public/dart/src/data_pipe.dart

index 2af863f5eee3453fc00276685e83d1020a11ddeb..9739be58b21cb787a12afe69cd1dfc14a7241532 100644

--- a/mojo/public/dart/src/data_pipe.dart

+++ b/mojo/public/dart/src/data_pipe.dart

@@ -107,7 +107,7 @@ class MojoDataPipeConsumer {

int read(ByteData data, [int numBytes = -1, int flags = 0]) {

if (handle == null) {

status = MojoResult.INVALID_ARGUMENT;

- return status;

+ return 0;

}

int data_numBytes = (numBytes == -1) ? data.lengthInBytes : numBytes;

@@ -115,7 +115,7 @@ class MojoDataPipeConsumer {

handle.h, data, data_numBytes, flags);

if (result == null) {

status = MojoResult.INVALID_ARGUMENT;

- return status;

+ return 0;

}

assert((result is List) && (result.length == 2));

status = new MojoResult(result[0]);