Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: mojo/public/dart/src/codec.dart

Issue 953953003: Introduce dartanalyze into our build. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Only run dartanalyze on the toplevel check target. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/dart/src/codec.dart
diff --git a/mojo/public/dart/src/codec.dart b/mojo/public/dart/src/codec.dart
index 677dc10a7b33b1976f296db1939cc9f6c7faceb0..b32cc818c44dc0ea28d1dc62b00732e19a51efb7 100644
--- a/mojo/public/dart/src/codec.dart
+++ b/mojo/public/dart/src/codec.dart
@@ -132,7 +132,7 @@ class Encoder {
void encodeUint8(int value, int offset) {
if (value < 0) {
- throw new MojoCodecError('$kErrorUnsigned: $val');
+ throw new MojoCodecError('$kErrorUnsigned: $value');
}
_buffer.buffer.setUint8(_base + offset, value);
}
@@ -142,7 +142,7 @@ class Encoder {
void encodeUint16(int value, int offset) {
if (value < 0) {
- throw new MojoCodecError('$kErrorUnsigned: $val');
+ throw new MojoCodecError('$kErrorUnsigned: $value');
}
_buffer.buffer.setUint16(_base + offset, value, Endianness.LITTLE_ENDIAN);
}
@@ -152,7 +152,7 @@ class Encoder {
void encodeUint32(int value, int offset) {
if (value < 0) {
- throw new MojoCodecError('$kErrorUnsigned: $val');
+ throw new MojoCodecError('$kErrorUnsigned: $value');
}
_buffer.buffer.setUint32(_base + offset, value, Endianness.LITTLE_ENDIAN);
}
@@ -162,7 +162,7 @@ class Encoder {
void encodeUint64(int value, int offset) {
if (value < 0) {
- throw new MojoCodecError('$kErrorUnsigned: $val');
+ throw new MojoCodecError('$kErrorUnsigned: $value');
}
_buffer.buffer.setUint64(_base + offset, value, Endianness.LITTLE_ENDIAN);
}
@@ -483,10 +483,10 @@ class Encoder {
void appendUint64Array(List<int> value) =>
appendBytes(new Uint8List.view(new Uint64List.fromList(value).buffer));
- void appendFloatArray(List<int> value) =>
+ void appendFloatArray(List<double> value) =>
appendBytes(new Uint8List.view(new Float32List.fromList(value).buffer));
- void appendDoubleArray(List<int> value) =>
+ void appendDoubleArray(List<double> value) =>
appendBytes(new Uint8List.view(new Float64List.fromList(value).buffer));
Encoder encoderForMap(int offset) {

Powered by Google App Engine
This is Rietveld 408576698