Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: mojo/public/dart/src/data_pipe.dart

Issue 953953003: Introduce dartanalyze into our build. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/dart/src/data_pipe.dart
diff --git a/mojo/public/dart/src/data_pipe.dart b/mojo/public/dart/src/data_pipe.dart
index 2af863f5eee3453fc00276685e83d1020a11ddeb..bfc47b20720031111401aa442e84b5b1a51878d0 100644
--- a/mojo/public/dart/src/data_pipe.dart
+++ b/mojo/public/dart/src/data_pipe.dart
@@ -41,7 +41,7 @@ class MojoDataPipeProducer {
MojoDataPipeProducer(
this.handle, [this.status = MojoResult.OK, this.elementBytes = 1]);
- int write(ByteData data, [int numBytes = -1, int flags = 0]) {
+ MojoResult write(ByteData data, [int numBytes = -1, int flags = 0]) {
if (handle == null) {
status = MojoResult.INVALID_ARGUMENT;
return status;
@@ -104,7 +104,7 @@ class MojoDataPipeConsumer {
MojoDataPipeConsumer(
this.handle, [this.status = MojoResult.OK, this.elementBytes = 1]);
- int read(ByteData data, [int numBytes = -1, int flags = 0]) {
+ MojoResult read(ByteData data, [int numBytes = -1, int flags = 0]) {
zra 2015/02/24 23:04:39 This should return the number of bytes read, so re
if (handle == null) {
status = MojoResult.INVALID_ARGUMENT;
return status;
@@ -150,7 +150,7 @@ class MojoDataPipeConsumer {
return status;
}
- int query() => read(null, 0, FLAG_QUERY);
+ MojoResult query() => read(null, 0, FLAG_QUERY);
zra 2015/02/24 23:04:39 back to int with fix to read.
}

Powered by Google App Engine
This is Rietveld 408576698