Introduce dartanalyze into our build.

mojo/public/dart/src/data_pipe.dart

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 part of core;
 
 
 class _MojoDataPipeNatives {
   static List MojoCreateDataPipe(
       int elementBytes, int capacityBytes, int flags)
@@ skipping 23 matching lines @@
   static const int FLAG_NONE = 0;
   static const int FLAG_ALL_OR_NONE = 1 << 0;
 
   MojoHandle handle;
   MojoResult status;
   final int elementBytes;
 
   MojoDataPipeProducer(
       this.handle, [this.status = MojoResult.OK, this.elementBytes = 1]);
 
-  int write(ByteData data, [int numBytes = -1, int flags = 0]) {
+  MojoResult write(ByteData data, [int numBytes = -1, int flags = 0]) {
     if (handle == null) {
       status = MojoResult.INVALID_ARGUMENT;
       return status;
     }
 
     int data_numBytes = (numBytes == -1) ? data.lengthInBytes : numBytes;
     List result = _MojoDataPipeNatives.MojoWriteData(
         handle.h, data, data_numBytes, flags);
     if (result == null) {
       status = MojoResult.INVALID_ARGUMENT;
@@ skipping 42 matching lines @@
   static const int FLAG_QUERY = 1 << 2;
   static const int FLAG_PEEK = 1 << 3;
 
   MojoHandle handle;
   MojoResult status;
   final int elementBytes;
 
   MojoDataPipeConsumer(
       this.handle, [this.status = MojoResult.OK, this.elementBytes = 1]);
 
-  int read(ByteData data, [int numBytes = -1, int flags = 0]) {
+  MojoResult read(ByteData data, [int numBytes = -1, int flags = 0]) {

[zra, 2015/02/24 23:04:39]

This should return the number of bytes read, so returning int is correct, but
the 'return status's below should become return 0.

     if (handle == null) {
       status = MojoResult.INVALID_ARGUMENT;
       return status;
     }
 
     int data_numBytes = (numBytes == -1) ? data.lengthInBytes : numBytes;
     List result = _MojoDataPipeNatives.MojoReadData(
         handle.h, data, data_numBytes, flags);
     if (result == null) {
       status = MojoResult.INVALID_ARGUMENT;
@@ skipping 25 matching lines @@
   MojoResult endRead(int bytesRead) {
     if (handle == null) {
       status = MojoResult.INVALID_ARGUMENT;
       return status;
     }
     int result = _MojoDataPipeNatives.MojoEndReadData(handle.h, bytesRead);
     status = new MojoResult(result);
     return status;
   }
 
-  int query() => read(null, 0, FLAG_QUERY);
+  MojoResult query() => read(null, 0, FLAG_QUERY);

[zra, 2015/02/24 23:04:39]

back to int with fix to read.

 }
 
 
 class MojoDataPipe {
   static const int FLAG_NONE = 0;
   static const int DEFAULT_ELEMENT_SIZE = 1;
   static const int DEFAULT_CAPACITY = 0;
 
   MojoDataPipeProducer producer;
   MojoDataPipeConsumer consumer;
@@ skipping 18 matching lines @@
     MojoHandle consumerHandle = new MojoHandle(result[2]);
     MojoDataPipe pipe = new MojoDataPipe._internal();
     pipe.producer = new MojoDataPipeProducer(
         producerHandle, new MojoResult(result[0]), elementBytes);
     pipe.consumer = new MojoDataPipeConsumer(
         consumerHandle, new MojoResult(result[0]), elementBytes);
     pipe.status = new MojoResult(result[0]);
     return pipe;
   }
 }