Issue 953903004: Factor sky-toolbar into a componet and use a proper material shadow

Issue 953903004: Factor sky-toolbar into a componet and use a proper material shadow (Closed)

Created:
5 years, 10 months ago by abarth-chromium

Modified:
5 years, 10 months ago

Reviewers:
eseidel

CC:
esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Factor sky-toolbar into a componet and use a proper material shadow R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2da0076b3f4bea2b6327988d9bf8895a39970afd

Patch Set 1 #

Total comments: 4

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -8 lines)			Patch
M	sky/examples/stocks/stock.sky	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/examples/stocks/stocks.sky	View	3 chunks	+5 lines, -7 lines	4 comments	Download
A	sky/framework/sky-toolbar.sky	View	1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

eseidel

lgtm https://codereview.chromium.org/953903004/diff/1/sky/examples/stocks/stocks.sky File sky/examples/stocks/stocks.sky (right): https://codereview.chromium.org/953903004/diff/1/sky/examples/stocks/stocks.sky#newcode33 sky/examples/stocks/stocks.sky:33: z-index: 1; Should the level= stuff do this? ...

5 years, 10 months ago (2015-02-24 18:34:37 UTC) #2

abarth-chromium

https://codereview.chromium.org/953903004/diff/1/sky/examples/stocks/stocks.sky File sky/examples/stocks/stocks.sky (right): https://codereview.chromium.org/953903004/diff/1/sky/examples/stocks/stocks.sky#newcode33 sky/examples/stocks/stocks.sky:33: z-index: 1; On 2015/02/24 at 18:34:36, eseidel wrote: > ...

5 years, 10 months ago (2015-02-24 18:45:21 UTC) #3

abarth-chromium

5 years, 10 months ago (2015-02-24 18:47:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2da0076b3f4bea2b6327988d9bf8895a39970afd (presubmit successful).

Expand Messages | Collapse Messages