Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Unified Diff: sky/examples/stocks/stocks.sky

Issue 953903004: Factor sky-toolbar into a componet and use a proper material shadow (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/examples/stocks/stock.sky ('k') | sky/framework/sky-toolbar.sky » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/examples/stocks/stocks.sky
diff --git a/sky/examples/stocks/stocks.sky b/sky/examples/stocks/stocks.sky
index 0d870d04b175032dd9442c9249b43bd0420da6dd..5db7799cfb85238f8904576f9bff8d406b399b47 100644
--- a/sky/examples/stocks/stocks.sky
+++ b/sky/examples/stocks/stocks.sky
@@ -7,6 +7,7 @@
<import src="/sky/framework/sky-element.sky" />
<import src="/sky/framework/sky-icon.sky" />
<import src="/sky/framework/sky-scrollable.sky" />
+<import src="/sky/framework/sky-toolbar.sky" />
<import src="stock.sky" as='view'/>
<import src='companylist.sky' as='model'/>
@@ -22,25 +23,22 @@
}
sky-drawer {
position: absolute;
- z-index: 1;
+ z-index: 2;
top: 0;
left: 0;
bottom: 0;
right: 0;
}
sky-toolbar {
- display: flex;
- align-items: center;
+ z-index: 1;
eseidel 2015/02/24 18:34:36 Should the level= stuff do this?
abarth-chromium 2015/02/24 18:45:20 That's an interesting question. I'm not sure.
background-color: #3F51B5;
color: white;
- height: 56px;
- box-shadow: 0px 4px 4px grey;
}
sky-icon {
display: flex;
justify-content: center;
align-items: center;
- padding: 7px;
+ padding: 8px;
margin: 0 4px;
color: black;
}
@@ -55,7 +53,7 @@
<sky-drawer id="drawer">
I am drawer
</sky-drawer>
- <sky-toolbar>
+ <sky-toolbar level="2">
eseidel 2015/02/24 18:34:36 We might want to name the levels.
abarth-chromium 2015/02/24 18:45:20 Yeah... I think the spec uses numbers but names w
<sky-icon id="menu" type="navigation/menu_white" size="24" />
<div id="title">I am a stocks app</div>
<sky-icon type="action/search_white" size="24" />
« no previous file with comments | « sky/examples/stocks/stock.sky ('k') | sky/framework/sky-toolbar.sky » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698