Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 953883002: We don't need a lock for the output queue on the main thread (Closed)

Created:
5 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 10 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

We don't need a lock for the output queue on the main thread The output queue is supposed to be a lock-free anyways, we're just temporarily abusing it by having multiple producers. For those, we need the lock when enqueuing jobs. BUG=none R=yangguo@chromium.org LOG=n Committed: https://crrev.com/09e0f6e21f2ba68fa6ed80702ca73b1808a6c782 Cr-Commit-Position: refs/heads/master@{#26824}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/optimizing-compiler-thread.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 10 months ago (2015-02-24 13:16:13 UTC) #1
Yang
On 2015/02/24 13:16:13, jochen (slow) wrote: lgtm.
5 years, 10 months ago (2015-02-24 13:21:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953883002/1
5 years, 10 months ago (2015-02-24 13:21:52 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 13:42:11 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 13:42:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09e0f6e21f2ba68fa6ed80702ca73b1808a6c782
Cr-Commit-Position: refs/heads/master@{#26824}

Powered by Google App Engine
This is Rietveld 408576698