src/optimizing-compiler-thread.cc - Issue 953883002: We don't need a lock for the output queue on the main thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/optimizing-compiler-thread.cc

Issue 953883002: We don't need a lock for the output queue on the main thread (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/optimizing-compiler-thread.cc

diff --git a/src/optimizing-compiler-thread.cc b/src/optimizing-compiler-thread.cc

index 153b618e438f8bf942bdb19bbff7a7417264cb8a..98e31ed99b8c4e92485141049071e3d472c00898 100644

--- a/src/optimizing-compiler-thread.cc

+++ b/src/optimizing-compiler-thread.cc

@@ -246,7 +246,6 @@ void OptimizingCompilerThread::FlushInputQueue(bool restore_function_code) {

void OptimizingCompilerThread::FlushOutputQueue(bool restore_function_code) {

- base::LockGuard<base::Mutex> access_output_queue_(&output_queue_mutex_);

OptimizedCompileJob* job;

while (output_queue_.Dequeue(&job)) {

// OSR jobs are dealt with separately.

« no previous file with comments | « no previous file | no next file » | no next file with comments »