Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 953633002: Remove net::Filter direct dependency on IsSupportedMimeType (Closed)

Created:
5 years, 10 months ago by servolk
Modified:
5 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove net::Filter direct dependency on IsSupportedMimeType There is a widespread consensus that mime type checks don't belong to net/, they should be moved to content/. But in order to be able to do that, first we need to remove all direct dependencies on mime type checks under net/. This CL will remove such a direct dependency from net::Filter::FixupEncodingTypes. We'll introduce a new NetworkDelegate::IsSupportedMimeType API instead and that will be overridden by actual network delegate implementations that care about this (ChromeNetworkDelegate and ShellNetworkDelegate) BUG=318217

Patch Set 1 #

Patch Set 2 : Added LayeredNetworkDelegate::OnIsSupportedMimeType #

Patch Set 3 : Added NetworkDelegate::IsSupportedMimeType overrides for Chrome/shell delegates #

Patch Set 4 : Use NetworkDelegate::IsSupportedMimeType in net::Filter::FixupEncodingTypes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -4 lines) Patch
M chrome/browser/net/chrome_network_delegate.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M content/shell/browser/shell_network_delegate.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/browser/shell_network_delegate.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M net/base/layered_network_delegate.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/base/layered_network_delegate.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M net/base/network_delegate.h View 2 chunks +8 lines, -0 lines 0 comments Download
M net/base/network_delegate.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/base/network_delegate_impl.h View 1 chunk +6 lines, -0 lines 0 comments Download
M net/base/network_delegate_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M net/filter/filter.cc View 1 2 3 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
Ryan Sleevi
5 years, 10 months ago (2015-02-24 00:50:46 UTC) #3
//net not lgtm, per email discussion.

The goal is not to rework this dependency in //net through NetworkDelegate.

The first attempt is to remove this code entirely.
Barring that, the next attempt is to move this behaviour that is calling it all
the way into //content where it belongs.

Powered by Google App Engine
This is Rietveld 408576698