PlzNavigate: test updates post beforeUnload IPC refactor.

content/test/test_render_frame_host.h

Index: content/test/test_render_frame_host.h
diff --git a/content/test/test_render_frame_host.h b/content/test/test_render_frame_host.h
index fcf4a743655636f287c6fdd66b1c4cc16bcedf84..6106de45a850b374546c631dd530c49ff39d3b5c 100644
--- a/content/test/test_render_frame_host.h
+++ b/content/test/test_render_frame_host.h
@@ -86,6 +86,9 @@ class TestRenderFrameHost : public RenderFrameHostImpl,
       const base::FilePath* file_path_for_history_item,
       const std::vector<GURL>& redirects);
   void SendBeginNavigationWithURL(const GURL& url, bool has_user_gesture);
+  // PlzNavigate

[clamy, 2015/02/24 13:05:34]

nit: move the comment above SendBeginNavigationWithURL and add an empty line
before it.

[carlosk, 2015/02/24 16:38:56]

In fact I merged these two methods as they were practically the same anyway. And
updated its comment.

[clamy, 2015/02/25 14:29:49]

I think the merging is good but would prefer if the name was
SendRendererInitiatedNavigationRequest instead of SendBeginNavigationWithURL.
The second one implies that the only thing this method does is simulating a
BeginNavigation IPC while it only does so if PlzNavigate is enabled. I also find
that the other method name makes the NavigationController tests clearer. Not to
mention that I'm not very keen on having a PlzNavigate IPC called in the middle
of non PlzNavigate specific tests.

[carlosk, 2015/02/25 16:07:59]

Done.

+  void SendRendererInitiatedNavigationRequest(const GURL& url,

[clamy, 2015/02/24 13:05:34]

I think there should be a comment explaining what this function is doing.
Something like:
// Simulates the start of a renderer-initiated navigation. Currently this is a
no-op in the browser.
PlzNavigate: this simulates receiving a BeginNavigation IPC.

[carlosk, 2015/02/24 16:38:56]

Done.

+                                              bool has_user_gesture);
 
   void DidDisownOpener();
 
@@ -102,7 +105,7 @@ class TestRenderFrameHost : public RenderFrameHostImpl,
   // this simulates a BeforeUnload ACK from the renderer.
   // PlzNavigate: this simulates a BeforeUnload ACK from the renderer, and the
   // interaction with the IO thread up until the response is ready to commit.
-  void PrepareForCommit(const GURL& url);
+  void PrepareForCommit();
 
   // Simulate receiving a FrameHostMsg_BeforeUnloadHandlersPresent.
   void SendBeforeUnloadHandlersPresent(bool present);