PlzNavigate: test updates post beforeUnload IPC refactor.

content/test/test_render_frame_host.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_TEST_TEST_RENDER_FRAME_HOST_H_
 #define CONTENT_TEST_TEST_RENDER_FRAME_HOST_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 68 matching lines @@
       const std::vector<GURL>& redirects);
   void SendNavigateWithParameters(
       int page_id,
       const GURL& url,
       ui::PageTransition transition,
       const GURL& original_request_url,
       int response_code,
       const base::FilePath* file_path_for_history_item,
       const std::vector<GURL>& redirects);
   void SendBeginNavigationWithURL(const GURL& url, bool has_user_gesture);
+  // PlzNavigate

[clamy, 2015/02/24 13:05:34]

nit: move the comment above SendBeginNavigationWithURL and add an empty line
before it.

[carlosk, 2015/02/24 16:38:56]

In fact I merged these two methods as they were practically the same anyway. And
updated its comment.

[clamy, 2015/02/25 14:29:49]

I think the merging is good but would prefer if the name was
SendRendererInitiatedNavigationRequest instead of SendBeginNavigationWithURL.
The second one implies that the only thing this method does is simulating a
BeginNavigation IPC while it only does so if PlzNavigate is enabled. I also find
that the other method name makes the NavigationController tests clearer. Not to
mention that I'm not very keen on having a PlzNavigate IPC called in the middle
of non PlzNavigate specific tests.

[carlosk, 2015/02/25 16:07:59]

Done.

+  void SendRendererInitiatedNavigationRequest(const GURL& url,

[clamy, 2015/02/24 13:05:34]

I think there should be a comment explaining what this function is doing.
Something like:
// Simulates the start of a renderer-initiated navigation. Currently this is a
no-op in the browser.
PlzNavigate: this simulates receiving a BeginNavigation IPC.

[carlosk, 2015/02/24 16:38:56]

Done.

+                                              bool has_user_gesture);
 
   void DidDisownOpener();
 
   // If set, navigations will appear to have cleared the history list in the
   // RenderFrame
   // (FrameHostMsg_DidCommitProvisionalLoad_Params::history_list_was_cleared).
   // False by default.
   void set_simulate_history_list_was_cleared(bool cleared) {
     simulate_history_list_was_cleared_ = cleared;
   }
 
   // Advances the RenderFrameHost (and through it the RenderFrameHostManager) to
   // a state where a new navigation can be committed by a renderer. Currently,
   // this simulates a BeforeUnload ACK from the renderer.
   // PlzNavigate: this simulates a BeforeUnload ACK from the renderer, and the
   // interaction with the IO thread up until the response is ready to commit.
-  void PrepareForCommit(const GURL& url);
+  void PrepareForCommit();
 
   // Simulate receiving a FrameHostMsg_BeforeUnloadHandlersPresent.
   void SendBeforeUnloadHandlersPresent(bool present);
 
   // Simulate receiving a FrameHostMsg_UnloadHandlersPresent.
   void SendUnloadHandlersPresent(bool present);
 
  private:
   TestRenderFrameHostCreationObserver child_creation_observer_;
 
   std::string contents_mime_type_;
 
   // See set_simulate_history_list_was_cleared() above.
   bool simulate_history_list_was_cleared_;
 
   DISALLOW_COPY_AND_ASSIGN(TestRenderFrameHost);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_TEST_TEST_RENDER_FRAME_HOST_H_