Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 953403002: Constructor without callback added to ProfilerMetricsProvider. (Closed)

Created:
5 years, 10 months ago by gayane -on leave until 09-2017
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Constructor without callback added to ProfilerMetricsProvider. As ProfilerMetricsProvider is used in same cases where network connection type is irrelevant, a constructor without the connection type callback is added to support those cases. Constructor with a callback was introduced in CL/937263002. BUG=455847 Committed: https://crrev.com/5bece2596244816b3ce8e4e0f78598c8fa28d350 Cr-Commit-Position: refs/heads/master@{#318086}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Constructor of provider is moved and comment added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M components/metrics/profiler/profiler_metrics_provider.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/metrics/profiler/profiler_metrics_provider.cc View 2 chunks +5 lines, -1 line 0 comments Download
M components/metrics/profiler/profiler_metrics_provider_unittest.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
gunsch
On 2015/02/25 16:49:22, gayane wrote: > mailto:gayane@chromium.org changed reviewers: > + mailto:asvitkine@chromium.org Great, thanks for ...
5 years, 10 months ago (2015-02-25 17:37:14 UTC) #2
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/953403002/diff/1/components/metrics/profiler/profiler_metrics_provider.h File components/metrics/profiler/profiler_metrics_provider.h (right): https://codereview.chromium.org/953403002/diff/1/components/metrics/profiler/profiler_metrics_provider.h#newcode23 components/metrics/profiler/profiler_metrics_provider.h:23: ProfilerMetricsProvider(); Nit: Add a comment that this creates ...
5 years, 10 months ago (2015-02-25 17:39:46 UTC) #3
gayane -on leave until 09-2017
Constructor of provider is moved and comment added. https://codereview.chromium.org/953403002/diff/1/components/metrics/profiler/profiler_metrics_provider.h File components/metrics/profiler/profiler_metrics_provider.h (right): https://codereview.chromium.org/953403002/diff/1/components/metrics/profiler/profiler_metrics_provider.h#newcode23 components/metrics/profiler/profiler_metrics_provider.h:23: ProfilerMetricsProvider(); ...
5 years, 10 months ago (2015-02-25 18:21:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953403002/20001
5 years, 10 months ago (2015-02-25 18:22:57 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-25 19:17:48 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 19:21:04 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5bece2596244816b3ce8e4e0f78598c8fa28d350
Cr-Commit-Position: refs/heads/master@{#318086}

Powered by Google App Engine
This is Rietveld 408576698