components/metrics/profiler/profiler_metrics_provider.cc - Issue 953403002: Constructor without callback added to ProfilerMetricsProvider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/profiler/profiler_metrics_provider.cc

Issue 953403002: Constructor without callback added to ProfilerMetricsProvider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Constructor of provider is moved and comment added Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/metrics/profiler/profiler_metrics_provider.h ('k') | components/metrics/profiler/profiler_metrics_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/metrics/profiler/profiler_metrics_provider.cc

diff --git a/components/metrics/profiler/profiler_metrics_provider.cc b/components/metrics/profiler/profiler_metrics_provider.cc

index bec5451dd00a8b77879acbcf299eeb3f78ad7d2f..16a0f278b3245d672dff77fa56810b8fcbd76022 100644

--- a/components/metrics/profiler/profiler_metrics_provider.cc

+++ b/components/metrics/profiler/profiler_metrics_provider.cc

@@ -117,6 +117,9 @@ bool IsCellularEnabledByExperiment() {

} // namespace

+ProfilerMetricsProvider::ProfilerMetricsProvider() : has_profiler_data_(false) {

ProfilerMetricsProvider::ProfilerMetricsProvider(

const base::Callback<void(bool*)>& cellular_callback)

: has_profiler_data_(false), cellular_callback_(cellular_callback) {

@@ -158,7 +161,8 @@ void ProfilerMetricsProvider::RecordProfilerData(

bool ProfilerMetricsProvider::IsCellularConnection() {

bool is_cellular = false;

- // For android get current connection type from NetworkMetricsProvider.

+// For android get current connection type from NetworkMetricsProvider if the

+// callback exists.

#if defined(OS_ANDROID)

if (!cellular_callback_.is_null())

cellular_callback_.Run(&is_cellular);