Chromium Code Reviews| Index: remoting/webapp/crd/js/server_log_entry.js |
| diff --git a/remoting/webapp/crd/js/server_log_entry.js b/remoting/webapp/crd/js/server_log_entry.js |
| index 7d848aa5b5a4a089f8909778f7108508fd933a75..b2a2a8c4b4fd1cc65ee59bc7f4245bac0831d1e5 100644 |
| --- a/remoting/webapp/crd/js/server_log_entry.js |
| +++ b/remoting/webapp/crd/js/server_log_entry.js |
| @@ -47,8 +47,10 @@ remoting.ServerLogEntry.KEY_SIGNAL_STRATEGY_TYPE_ = 'signal-strategy-type'; |
| remoting.ServerLogEntry.KEY_SIGNAL_STRATEGY_PROGRESS_ = |
| 'signal-strategy-progress'; |
| /** @private */ |
| -remoting.ServerLogEntry.KEY_SIGNAL_STRATEGY_ELAPSED_TIME_ = |
| - 'signal-strategy-elapsed-time'; |
| +remoting.ServerLogEntry.KEY_TIME_TO_REACH_A_SESSION_STATE_MS_ = |
| + 'time-to-reach-state'; |
|
Jamie
2015/02/26 20:32:06
I think simply "elapsed-time" is a better name for
anandc
2015/02/26 22:47:11
Done.
|
| + |
| + |
| /** |
| * @private |
| @@ -315,6 +317,7 @@ remoting.ServerLogEntry.prototype.addStatsField_ = function( |
| return (val != 0); |
| }; |
| + |
|
Jamie
2015/02/26 20:32:06
No need for an extra blank line here.
anandc
2015/02/26 22:47:11
Done.
|
| /** |
| * Makes a log entry for a "this session ID is old" event. |
| * |
| @@ -371,8 +374,6 @@ remoting.ServerLogEntry.makeSignalStrategyProgress = |
| entry.addSessionIdField(sessionId); |
| entry.set_(remoting.ServerLogEntry.KEY_SIGNAL_STRATEGY_TYPE_, strategyType); |
| entry.set_(remoting.ServerLogEntry.KEY_SIGNAL_STRATEGY_PROGRESS_, progress); |
| - entry.set_(remoting.ServerLogEntry.KEY_SIGNAL_STRATEGY_ELAPSED_TIME_, |
| - String(elapsedTimeInMs)); |
| return entry; |
| }; |
| @@ -467,6 +468,18 @@ remoting.ServerLogEntry.extractHostDataFrom_ = function(s) { |
| }; |
| /** |
| + * Adds a field to this log entry specifying the elapsed time since the start of |
| + * the session to the current session state. |
| + * @param {number} elapsedTimeInMs |
| + */ |
| +remoting.ServerLogEntry.prototype.addTimeToReachStateMs = |
| + function(elapsedTimeInMs) { |
| + this.set_(remoting.ServerLogEntry.KEY_TIME_TO_REACH_A_SESSION_STATE_MS_, |
| + String(elapsedTimeInMs)); |
| +}; |
| + |
| + |
| +/** |
| * Adds a field specifying the browser version to this log entry. |
| */ |
| remoting.ServerLogEntry.prototype.addChromeVersionField = function() { |