Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: remoting/webapp/crd/js/log_to_server.js

Issue 953223002: Include time elapsed since start of a remoting session in each log entry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove logging of elapsed time for session strategy progress. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/crd/js/log_to_server.js
diff --git a/remoting/webapp/crd/js/log_to_server.js b/remoting/webapp/crd/js/log_to_server.js
index 8b87f1b5c4efc7273b3cb4ce5f43f36ae5926294..e224e660a7612fb2ff3a2af375e139b269fd6dc8 100644
--- a/remoting/webapp/crd/js/log_to_server.js
+++ b/remoting/webapp/crd/js/log_to_server.js
@@ -72,6 +72,9 @@ remoting.LogToServer.prototype.logClientSessionStateChange =
entry.addHostFields();
entry.addChromeVersionField();
entry.addWebappVersionField();
+ // Log the time taken to get to this state from the time this session started.
+ var timeToReachThisState = new Date().getTime() - this.sessionStartTime_;
+ entry.addTimeToReachStateMs(timeToReachThisState);
Jamie 2015/02/26 20:32:06 This should either be added at a lower level (if y
anandc 2015/02/26 22:47:11 Done. Move further down in this function.
entry.addSessionIdField(this.sessionId_);
// Maybe clear the session start time, and log the session duration.
if (remoting.LogToServer.shouldAddDuration_(state) &&
« no previous file with comments | « no previous file | remoting/webapp/crd/js/server_log_entry.js » ('j') | remoting/webapp/crd/js/server_log_entry.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698