autofill - remove contentDescriptions on EditTexts

autofill - remove contentDescriptions on EditTexts

BUG=none

Committed: https://crrev.com/b23b8b4e42a2dbcebed77e7e1cda07cbc6dfa0f2
Cr-Commit-Position: refs/heads/master@{#318159}

[Evan Stade, 2015-02-25 01:42:55]

estade@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2015-02-25 16:40:51]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2015-02-25 16:40:51]

lgtm

[commit-bot: I haz the power, 2015-02-25 16:41:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/953163002/20001

[commit-bot: I haz the power, 2015-02-25 16:59:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-25 16:59:31]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Evan Stade, 2015-02-25 22:07:58]

estade@chromium.org changed reviewers:
+ newt@chromium.org

[Evan Stade, 2015-02-25 22:07:58]

+newt for OWNERS

[newt (away), 2015-02-25 23:18:05]

https://codereview.chromium.org/953163002/diff/20001/chrome/android/java/res/...
File chrome/android/java/res/layout/autofill_profile_editor.xml (left):

https://codereview.chromium.org/953163002/diff/20001/chrome/android/java/res/...
chrome/android/java/res/layout/autofill_profile_editor.xml:65:
android:contentDescription="@string/autofill_profile_editor_phone_number" />
Don't remove the contentDescriptions for EditTexts inside FloatLabelLayout. For
these EditTexts, the contentDescription is needed when the field is focused, at
which point the hint text is removed.

[Evan Stade, 2015-02-25 23:55:53]

On 2015/02/25 23:18:05, newt wrote:
>
https://codereview.chromium.org/953163002/diff/20001/chrome/android/java/res/...
> File chrome/android/java/res/layout/autofill_profile_editor.xml (left):
> 
>
https://codereview.chromium.org/953163002/diff/20001/chrome/android/java/res/...
> chrome/android/java/res/layout/autofill_profile_editor.xml:65:
> android:contentDescription="@string/autofill_profile_editor_phone_number" />
> Don't remove the contentDescriptions for EditTexts inside FloatLabelLayout.
For
> these EditTexts, the contentDescription is needed when the field is focused,
at
> which point the hint text is removed.

Dominic told me this: "we shouldn't ever have a contentDescription for an
EditText, it overrides the value." Perhaps there's a better solution?

You two are the domain experts so I'll defer to whatever you decide.

[dmazzoni, 2015-02-26 00:10:05]

On Wed, Feb 25, 2015 at 3:55 PM, <estade@chromium.org> wrote:

> Dominic told me this: "we shouldn't ever have a contentDescription for an
> EditText, it overrides the value." Perhaps there's a better solution?
>

Yeah, the broken behavior is that if you have a contentDescription in an
edit field, then if you move the cursor within the field (using the volume
keys is one easy shortcut to do this) you hear the text of the
contentDescription instead of the text you're editing. I think it's an
awful bug but it's been like that for a long time.

The best option is to use the hint text. If you want the hint to be spoken
when focused, you can create a subclass of EditText that sets the hint
explicitly in the AccessibilityNodeInfo, it'd only be a few lines of code.

- Dominic


>
> You two are the domain experts so I'll defer to whatever you decide.
>
>
> https://codereview.chromium.org/953163002/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[newt (away), 2015-02-26 00:32:13]

> Yeah, the broken behavior is that if you have a contentDescription in an edit
field, then if you move the cursor within the field (using the volume keys is
one easy shortcut to do this) you hear the text of the contentDescription
instead of the text you're editing. I think it's an awful bug but it's been like
that for a long time.

Woah. That's a fun bug :(

In that light, let's just remove the contentDescriptions for those EditTexts.
With the label just above the EditText, I think the meaning of the EditText is
clear enough.

[newt (away), 2015-02-26 00:32:24]

lgtm

[Evan Stade, 2015-02-26 00:35:10]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-02-26 00:36:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/953163002/20001

[commit-bot: I haz the power, 2015-02-26 00:39:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-26 00:40:10]

Patchset 2 (id:??) landed as
https://crrev.com/b23b8b4e42a2dbcebed77e7e1cda07cbc6dfa0f2
Cr-Commit-Position: refs/heads/master@{#318159}