Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Side by Side Diff: chrome/android/java/res/layout/autofill_profile_editor.xml

Issue 953163002: autofill - remove contentDescriptions on EditTexts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/android/java/res/layout/autofill_credit_card_editor.xml ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <ScrollView xmlns:android="http://schemas.android.com/apk/res/android" 6 <ScrollView xmlns:android="http://schemas.android.com/apk/res/android"
7 xmlns:app="http://schemas.android.com/apk/res-auto" 7 xmlns:app="http://schemas.android.com/apk/res-auto"
8 android:layout_width="match_parent" 8 android:layout_width="match_parent"
9 android:layout_height="match_parent" 9 android:layout_height="match_parent"
10 android:fillViewport="true" > 10 android:fillViewport="true" >
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 android:id="@+id/phone_number_label" 54 android:id="@+id/phone_number_label"
55 android:layout_width="match_parent" 55 android:layout_width="match_parent"
56 android:layout_height="wrap_content" > 56 android:layout_height="wrap_content" >
57 <EditText 57 <EditText
58 android:id="@+id/phone_number_edit" 58 android:id="@+id/phone_number_edit"
59 android:layout_width="match_parent" 59 android:layout_width="match_parent"
60 android:layout_height="wrap_content" 60 android:layout_height="wrap_content"
61 android:imeOptions="flagNoExtractUi" 61 android:imeOptions="flagNoExtractUi"
62 android:inputType="phone" 62 android:inputType="phone"
63 android:singleLine="true" 63 android:singleLine="true"
64 android:hint="@string/autofill_profile_editor_phone_number" 64 android:hint="@string/autofill_profile_editor_phone_number" />
65 android:contentDescription="@string/autofill_profile_editor_ phone_number" />
newt (away) 2015/02/25 23:18:04 Don't remove the contentDescriptions for EditTexts
66 </org.chromium.chrome.browser.widget.FloatLabelLayout> 65 </org.chromium.chrome.browser.widget.FloatLabelLayout>
67 66
68 <org.chromium.chrome.browser.widget.FloatLabelLayout 67 <org.chromium.chrome.browser.widget.FloatLabelLayout
69 android:id="@+id/email_address_label" 68 android:id="@+id/email_address_label"
70 android:layout_width="match_parent" 69 android:layout_width="match_parent"
71 android:layout_height="wrap_content" > 70 android:layout_height="wrap_content" >
72 <EditText 71 <EditText
73 android:id="@+id/email_address_edit" 72 android:id="@+id/email_address_edit"
74 android:layout_width="match_parent" 73 android:layout_width="match_parent"
75 android:layout_height="wrap_content" 74 android:layout_height="wrap_content"
76 android:imeOptions="flagNoExtractUi" 75 android:imeOptions="flagNoExtractUi"
77 android:inputType="textEmailAddress" 76 android:inputType="textEmailAddress"
78 android:singleLine="true" 77 android:singleLine="true"
79 android:hint="@string/autofill_profile_editor_email_address" 78 android:hint="@string/autofill_profile_editor_email_address" />
80 android:contentDescription="@string/autofill_profile_editor_ email_address" />
81 </org.chromium.chrome.browser.widget.FloatLabelLayout> 79 </org.chromium.chrome.browser.widget.FloatLabelLayout>
82 80
83 </LinearLayout> 81 </LinearLayout>
84 82
85 <View style="@style/ButtonBarTopSpacer" /> 83 <View style="@style/ButtonBarTopSpacer" />
86 <View style="@style/ButtonBarTopDivider" /> 84 <View style="@style/ButtonBarTopDivider" />
87 85
88 <LinearLayout style="@style/ButtonBar" > 86 <LinearLayout style="@style/ButtonBar" >
89 <Button 87 <Button
90 android:id="@+id/autofill_profile_delete" 88 android:id="@+id/autofill_profile_delete"
91 style="@style/ButtonBarButton" 89 style="@style/ButtonBarButton"
92 android:text="@string/delete" /> 90 android:text="@string/delete" />
93 91
94 <Button 92 <Button
95 android:id="@+id/autofill_profile_cancel" 93 android:id="@+id/autofill_profile_cancel"
96 style="@style/ButtonBarButton" 94 style="@style/ButtonBarButton"
97 android:text="@string/cancel" /> 95 android:text="@string/cancel" />
98 96
99 <Button 97 <Button
100 android:id="@+id/autofill_profile_save" 98 android:id="@+id/autofill_profile_save"
101 style="@style/ButtonBarButton" 99 style="@style/ButtonBarButton"
102 android:text="@string/save" /> 100 android:text="@string/save" />
103 </LinearLayout> 101 </LinearLayout>
104 </LinearLayout> 102 </LinearLayout>
105 103
106 </ScrollView> 104 </ScrollView>
OLDNEW
« no previous file with comments | « chrome/android/java/res/layout/autofill_credit_card_editor.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698