Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 952973003: Remove dead code from unit tests (Closed)

Created:
5 years, 10 months ago by rwlbuis
Modified:
5 years, 10 months ago
Reviewers:
pdr.
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove dead code from unit tests This code is not in use anymore. The selectionRootBounds code was likely missed in https://codereview.chromium.org/781743002. BUG=439559 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190790

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -58 lines) Patch
M Source/web/PopupMenuTest.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/web/tests/PageSerializerTest.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/web/tests/WebViewTest.cpp View 3 chunks +1 line, -50 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL
5 years, 10 months ago (2015-02-24 23:14:23 UTC) #2
pdr.
LGTM. Dead code is broken code.
5 years, 10 months ago (2015-02-24 23:16:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952973003/1
5 years, 10 months ago (2015-02-24 23:17:44 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 01:47:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190790

Powered by Google App Engine
This is Rietveld 408576698